Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-13224 build test: Build and test on EL9 #12176

Merged
merged 4 commits into from
Aug 9, 2023
Merged

Conversation

brianjmurrell
Copy link
Contributor

@brianjmurrell brianjmurrell commented May 20, 2023

Remove production of the version stash. It's not necessary any longer.

Add a Fixes commit pragma to allow a PR to fix more than one issue that
might be in the skip list.

Remove libfabric along with any daos packages prior to installing daos,
to ensure that the correct libfabric is installed.

Remove use of lsb_release as it's gone in EL9. Use /etc/os-release
instead.

s-nail replaces mail[x] for sending e-mail on EL9.

Remove ci/functional/required_packages.sh and move all functional test
dependency specifications into RPMs as Requires:.

Add a client-tests-mpich subpackage for mpich test dependencies.

Remove the "Scan EL 8 RPMs" stage due to Jenkinsfile size limitations.

Fixes: SRE-1899 DAOS-13225

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
    • No code related to failed tests was modified
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@brianjmurrell brianjmurrell self-assigned this May 20, 2023
@github-actions
Copy link

github-actions bot commented May 20, 2023

Bug-tracker data:
Ticket title is 'Update DAOS RPM build for EL9'
Status is 'In Progress'
Errors are component not formatted correctly
https://daosio.atlassian.net/browse/DAOS-13224

Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-12176/3/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

FYI: Errors found in lines not modified in the patch:

utils/rpms/packaging/rpm_chrootbuild:107:
(lint) Use "${array[@]}" (with quotes) to prevent whitespace problems. [SC2048]
(lint) Use "${array[@]}" (with quotes) to prevent whitespace problems. [SC2048]

utils/rpms/packaging/rpm_chrootbuild:108:
(lint) eval negates the benefit of arrays. Drop eval to preserve whitespace/symbols (or eval as string). [SC2294]

ci/provisioning/post_provision_config_common_functions.sh Outdated Show resolved Hide resolved
@daosbuild1
Copy link
Collaborator

Test stage Python Bandit check completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12176/84/execution/node/124/log

@daosbuild1 daosbuild1 dismissed their stale review June 5, 2023 19:20

Updated patch

Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-12176/84/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

FYI: Errors found in lines not modified in the patch:

utils/rpms/packaging/rpm_chrootbuild:118:
(lint) Use "${array[@]}" (with quotes) to prevent whitespace problems. [SC2048]
(lint) Use "${array[@]}" (with quotes) to prevent whitespace problems. [SC2048]

utils/rpms/packaging/rpm_chrootbuild:119:
(lint) eval negates the benefit of arrays. Drop eval to preserve whitespace/symbols (or eval as string). [SC2294]

ci/provisioning/post_provision_config_common_functions.sh Outdated Show resolved Hide resolved
ci/provisioning/post_provision_config_common_functions.sh Outdated Show resolved Hide resolved
ci/provisioning/post_provision_config_common_functions.sh Outdated Show resolved Hide resolved
utils/rpms/packaging/Dockerfile.mockbuild Outdated Show resolved Hide resolved
@daosbuild1
Copy link
Collaborator

@daosbuild1
Copy link
Collaborator

Test stage Python Bandit check completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12176/85/execution/node/133/log

@daosbuild1 daosbuild1 dismissed their stale review June 6, 2023 01:40

Updated patch

Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-12176/85/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

FYI: Errors found in lines not modified in the patch:

utils/rpms/packaging/rpm_chrootbuild:118:
(lint) Use "${array[@]}" (with quotes) to prevent whitespace problems. [SC2048]
(lint) Use "${array[@]}" (with quotes) to prevent whitespace problems. [SC2048]

utils/rpms/packaging/rpm_chrootbuild:119:
(lint) eval negates the benefit of arrays. Drop eval to preserve whitespace/symbols (or eval as string). [SC2294]

ci/provisioning/post_provision_config_common_functions.sh Outdated Show resolved Hide resolved
ci/provisioning/post_provision_config_common_functions.sh Outdated Show resolved Hide resolved
ci/provisioning/post_provision_config_common_functions.sh Outdated Show resolved Hide resolved
utils/rpms/packaging/Dockerfile.mockbuild Outdated Show resolved Hide resolved
@daosbuild1
Copy link
Collaborator

@daosbuild1 daosbuild1 dismissed their stale review June 6, 2023 01:50

Updated patch

Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-12176/86/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

FYI: Errors found in lines not modified in the patch:

utils/rpms/packaging/rpm_chrootbuild:118:
(lint) Use "${array[@]}" (with quotes) to prevent whitespace problems. [SC2048]
(lint) Use "${array[@]}" (with quotes) to prevent whitespace problems. [SC2048]

utils/rpms/packaging/rpm_chrootbuild:119:
(lint) eval negates the benefit of arrays. Drop eval to preserve whitespace/symbols (or eval as string). [SC2294]

ci/provisioning/post_provision_config_common_functions.sh Outdated Show resolved Hide resolved
ci/provisioning/post_provision_config_common_functions.sh Outdated Show resolved Hide resolved
ci/provisioning/post_provision_config_common_functions.sh Outdated Show resolved Hide resolved
utils/rpms/packaging/Dockerfile.mockbuild Outdated Show resolved Hide resolved
@daosbuild1
Copy link
Collaborator

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12176/87/execution/node/327/log

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12176/88/execution/node/245/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12176/88/execution/node/248/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12176/88/execution/node/242/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.4 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12176/88/execution/node/237/log

@daosbuild1
Copy link
Collaborator

Test stage Functional on Leap 15.4 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12176/89/execution/node/538/log

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12176/89/execution/node/616/log

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12176/89/execution/node/600/log

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12176/90/execution/node/220/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12176/90/execution/node/225/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12176/90/execution/node/226/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.4 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12176/90/execution/node/248/log

Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

FYI: Errors found in lines not modified in the patch:

ci/rpm/build_success.sh:12:
(lint) ShellCheck can't follow non-constant source. Use a directive to specify location. [SC1090]

utils/rpms/packaging/rpm_chrootbuild:118:
(lint) Use "${array[@]}" (with quotes) to prevent whitespace problems. [SC2048]
(lint) Use "${array[@]}" (with quotes) to prevent whitespace problems. [SC2048]

utils/rpms/packaging/rpm_chrootbuild:119:
(lint) eval negates the benefit of arrays. Drop eval to preserve whitespace/symbols (or eval as string). [SC2294]

daltonbohning
daltonbohning previously approved these changes Jul 5, 2023
@brianjmurrell brianjmurrell changed the title Build on EL9 DAOS-13224 build: Build and test on EL9 Jul 6, 2023
@brianjmurrell brianjmurrell changed the title DAOS-13224 build: Build and test on EL9 DAOS-13224 build test: Build and test on EL9 Jul 6, 2023
JohnMalmberg
JohnMalmberg previously approved these changes Jul 6, 2023
@brianjmurrell brianjmurrell requested a review from a team July 6, 2023 14:02
@brianjmurrell brianjmurrell added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Jul 6, 2023
Comment on lines +24 to +28
if [ ! -f .flake8 ]; then
echo " No .flake8, skipping flake checks"
exit 0
fi

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is. I don't recall the specific issue though. I am trying to make the githooks more portable to more repositories and must have run into some issue with .flake8 being missing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea.

Comment on lines +13 to +21

if [ -f utils/cq/daos_pylint.py ]; then
if [ "$TARGET" = "HEAD" ]; then
echo " Checking against HEAD"
git diff HEAD --name-only | ./utils/cq/daos_pylint.py --files-from-stdin
else
echo " Checking against branch ${TARGET}"
git diff "$TARGET"... --name-only | ./utils/cq/daos_pylint.py --files-from-stdin
fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment for here. On this branch the files tested for do exist.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, it is likely due to trying to use the same githooks in other repos.

daos (2.5.100-7) unstable; urgency=medium

[ Brian J. Murrell ]
* NOOP change to keep in parity with RPM version
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's no a NOOP

@@ -56,6 +56,7 @@ def _module_func(self, command, *arguments): # pylint: disable=no-self-use

# pylint: disable=consider-using-with
try:
print(f"Going to run {cmd}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debug left in?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. I left that in intentionally. I run into issues with this whole code path enough times that I think it's helpful to have that here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will appear in the build output for users, although I suppose most other commands do anyway.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. I think that is good though. It's providing some transparency about how CI is setting up the environment for MPI. It helps users that want to replicate CI have more understanding of what they need to do.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This results in quite a bit of debug that seems to only add the order of possible commands from what ia already printed, e.g.

2023-07-06 01:43:11,496 parameters       L0143 DEBUG| PARAMS (key=mpi_type, path=/run/job_manager/*, default=mpich) => 'mpich'
2023-07-06 01:43:11,497 output           L0696 DEBUG| [stdout] Going to run ['/usr/share/lmod/lmod/libexec/lmod', 'python', 'is-loaded', 'mpi/mpich-x86_64']
2023-07-06 01:43:11,497 output           L0696 DEBUG| [stdout] 

2023-07-06 01:43:11,613 output           L0696 DEBUG| [stdout] Going to run ['/usr/share/lmod/lmod/libexec/lmod', 'python', 'is-loaded', 'gnu-mpich']
2023-07-06 01:43:11,614 output           L0696 DEBUG| [stdout] 

2023-07-06 01:43:11,731 output           L0696 DEBUG| [stdout] Going to run ['/usr/share/lmod/lmod/libexec/lmod', 'python', 'is-loaded', 'mpi/mlnx_openmpi-x86_64']
2023-07-06 01:43:11,731 output           L0696 DEBUG| [stdout] 

2023-07-06 01:43:11,849 output           L0696 DEBUG| [stdout] Going to run ['/usr/share/lmod/lmod/libexec/lmod', 'python', 'is-loaded', 'mpi/openmpi3-x86_64']
2023-07-06 01:43:11,849 output           L0696 DEBUG| [stdout] 

2023-07-06 01:43:11,966 output           L0696 DEBUG| [stdout] Going to run ['/usr/share/lmod/lmod/libexec/lmod', 'python', 'is-loaded', 'gnu-openmpi']
2023-07-06 01:43:11,966 output           L0696 DEBUG| [stdout] 

2023-07-06 01:43:12,084 output           L0696 DEBUG| [stdout] Going to run ['/usr/share/lmod/lmod/libexec/lmod', 'python', 'is-loaded', 'mpi/openmpi-x86_64']
2023-07-06 01:43:12,084 output           L0696 DEBUG| [stdout] 

2023-07-06 01:43:12,201 output           L0696 DEBUG| [stdout] Trying to load mpi/mpich-x86_64
2023-07-06 01:43:12,201 output           L0696 DEBUG| [stdout] 

2023-07-06 01:43:12,202 output           L0696 DEBUG| [stdout] Going to run ['/usr/share/lmod/lmod/libexec/lmod', 'python', 'is-avail', 'mpi/mpich-x86_64']
2023-07-06 01:43:12,202 output           L0696 DEBUG| [stdout] 

2023-07-06 01:43:12,321 output           L0696 DEBUG| [stdout] Going to run ['/usr/share/lmod/lmod/libexec/lmod', 'python', 'load', 'mpi/mpich-x86_64']
2023-07-06 01:43:12,321 output           L0696 DEBUG| [stdout] 

2023-07-06 01:43:12,447 output           L0696 DEBUG| [stdout] Loaded mpi/mpich-x86_64
2023-07-06 01:43:12,447 output           L0696 DEBUG| [stdout] 

2023-07-06 01:43:12,448 parameters       L0143 DEBUG| PARAMS (key=bind_to, path=/run/mpirun/*, default=None) => None

from https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-12176/124/artifact/Functional%20Hardware%20Medium/ior/small.py/job.log.

I think it should be removed.

@@ -107,6 +108,7 @@ def _mpi_module(self, mpi):
self._module_func('unload', to_unload)

for to_load in load:
print(f"Trying to load {to_load}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debug left in.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

@brianjmurrell brianjmurrell requested review from a team and removed request for a team July 6, 2023 16:19
@brianjmurrell
Copy link
Contributor Author

Gatekeeper: Please DO NOT land this. I have removed daos-gatekeeper from the reviewers as all of the test-tool and middle-ware RPM PRs will need to land also or there will be massive amounts of test failures on master landings and timed runs -- where the EL9 test stage will run (it's only disabled for PRs, like Leap 15 is currently).

Given the time left this week, I don't think I can get all of those other PRs landed in a single day to prevent those massive failures for the 4 weeks I will be out on sabbatical starting Monday.

Signed-off-by: Brian J. Murrell <brian.murrell@intel.com>
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

FYI: Errors found in lines not modified in the patch:

ci/rpm/build_success.sh:12:
(lint) ShellCheck can't follow non-constant source. Use a directive to specify location. [SC1090]

utils/rpms/packaging/rpm_chrootbuild:118:
(lint) Use "${array[@]}" (with quotes) to prevent whitespace problems. [SC2048]
(lint) Use "${array[@]}" (with quotes) to prevent whitespace problems. [SC2048]

utils/rpms/packaging/rpm_chrootbuild:119:
(lint) eval negates the benefit of arrays. Drop eval to preserve whitespace/symbols (or eval as string). [SC2294]

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12176/125/execution/node/1111/log

@brianjmurrell
Copy link
Contributor Author

@JohnMalmberg @daltonbohning I'm hoping I can get some quick and timely reviews on the master merge that I had to do this PR for simply daos.spec and debian/changelog conflict update. @daos-stack/daos-gatekeeper willing, I am hoping to get this landed as early as possible tomorrow morning so that I can start landing the other side of the stack (test tools and middleware), hopefully all within the day so that there are not massive failures due to them being missing in tomorrow night's daily run which will include EL9 as a tested platform.

dnf_args.extend(
["--enablerepo=*-debuginfo", "libpmemobj", "python3", "openmpi", "gcc"])
["libpmemobj", "python3", "openmpi", "gcc"])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is "--enablerepo=*-debuginfo" not required with EL8 anymore or is this an accidental exclusion?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that was (always?) superfluous. Or perhaps some previous bug(s) that were preventing installing the necessary debug packages has been fixed. In any case, core file testing is one thing that I focused on in this PR for all platforms.

@@ -56,6 +56,7 @@ def _module_func(self, command, *arguments): # pylint: disable=no-self-use

# pylint: disable=consider-using-with
try:
print(f"Going to run {cmd}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This results in quite a bit of debug that seems to only add the order of possible commands from what ia already printed, e.g.

2023-07-06 01:43:11,496 parameters       L0143 DEBUG| PARAMS (key=mpi_type, path=/run/job_manager/*, default=mpich) => 'mpich'
2023-07-06 01:43:11,497 output           L0696 DEBUG| [stdout] Going to run ['/usr/share/lmod/lmod/libexec/lmod', 'python', 'is-loaded', 'mpi/mpich-x86_64']
2023-07-06 01:43:11,497 output           L0696 DEBUG| [stdout] 

2023-07-06 01:43:11,613 output           L0696 DEBUG| [stdout] Going to run ['/usr/share/lmod/lmod/libexec/lmod', 'python', 'is-loaded', 'gnu-mpich']
2023-07-06 01:43:11,614 output           L0696 DEBUG| [stdout] 

2023-07-06 01:43:11,731 output           L0696 DEBUG| [stdout] Going to run ['/usr/share/lmod/lmod/libexec/lmod', 'python', 'is-loaded', 'mpi/mlnx_openmpi-x86_64']
2023-07-06 01:43:11,731 output           L0696 DEBUG| [stdout] 

2023-07-06 01:43:11,849 output           L0696 DEBUG| [stdout] Going to run ['/usr/share/lmod/lmod/libexec/lmod', 'python', 'is-loaded', 'mpi/openmpi3-x86_64']
2023-07-06 01:43:11,849 output           L0696 DEBUG| [stdout] 

2023-07-06 01:43:11,966 output           L0696 DEBUG| [stdout] Going to run ['/usr/share/lmod/lmod/libexec/lmod', 'python', 'is-loaded', 'gnu-openmpi']
2023-07-06 01:43:11,966 output           L0696 DEBUG| [stdout] 

2023-07-06 01:43:12,084 output           L0696 DEBUG| [stdout] Going to run ['/usr/share/lmod/lmod/libexec/lmod', 'python', 'is-loaded', 'mpi/openmpi-x86_64']
2023-07-06 01:43:12,084 output           L0696 DEBUG| [stdout] 

2023-07-06 01:43:12,201 output           L0696 DEBUG| [stdout] Trying to load mpi/mpich-x86_64
2023-07-06 01:43:12,201 output           L0696 DEBUG| [stdout] 

2023-07-06 01:43:12,202 output           L0696 DEBUG| [stdout] Going to run ['/usr/share/lmod/lmod/libexec/lmod', 'python', 'is-avail', 'mpi/mpich-x86_64']
2023-07-06 01:43:12,202 output           L0696 DEBUG| [stdout] 

2023-07-06 01:43:12,321 output           L0696 DEBUG| [stdout] Going to run ['/usr/share/lmod/lmod/libexec/lmod', 'python', 'load', 'mpi/mpich-x86_64']
2023-07-06 01:43:12,321 output           L0696 DEBUG| [stdout] 

2023-07-06 01:43:12,447 output           L0696 DEBUG| [stdout] Loaded mpi/mpich-x86_64
2023-07-06 01:43:12,447 output           L0696 DEBUG| [stdout] 

2023-07-06 01:43:12,448 parameters       L0143 DEBUG| PARAMS (key=bind_to, path=/run/mpirun/*, default=None) => None

from https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-12176/124/artifact/Functional%20Hardware%20Medium/ior/small.py/job.log.

I think it should be removed.

@jolivier23 jolivier23 merged commit 74b68b8 into master Aug 9, 2023
34 of 35 checks passed
@jolivier23 jolivier23 deleted the bmurrell/el9 branch August 9, 2023 20:42
@brianjmurrell
Copy link
Contributor Author

I don't seem to be able to reply to #12176 (comment) directly, so will have to create a new comment here.

This results in quite a bit of debug that seems to only add the order of possible commands from what ia already printed, e.g.
...

I think it should be removed.

I left it in for transparency in how to reproduce what CI does to get the modules loaded. I can remove it if you think it's too much and too little value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Development

Successfully merging this pull request may close these issues.

7 participants