Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-13786 client: pool_free take rdlock for dp_co_list check #12469

Merged
merged 1 commit into from
Jun 23, 2023
Merged

DAOS-13786 client: pool_free take rdlock for dp_co_list check #12469

merged 1 commit into from
Jun 23, 2023

Conversation

kccain
Copy link
Contributor

@kccain kccain commented Jun 21, 2023 •
edited
Loading

Fix for Coverity CID 1444801

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@kccain
DAOS-13786 client: pool_free take rdlock for dp_co_list check
4f6afdf 
Fix for Coverity CID 1444801

Required-githooks: true

Signed-off-by: Kenneth Cain <kenneth.c.cain@intel.com>
@github-actions
Copy link

github-actions bot commented Jun 21, 2023 •
edited
Loading

Bug-tracker data:
Ticket title is '[coverity] 1444801 Data race condition'
Status is 'In Progress'
Labels: 'coverity,required_for_code_freeze'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-13786

@github-actions github-actions bot added priority Ticket has high priority (automatically managed) release-2.4 PR is eventually targeted for 2.4 labels Jun 21, 2023
daosbuild1
daosbuild1 reviewed Jun 21, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@kccain kccain requested a review from mchaarawi June 21, 2023 18:13
@kccain kccain marked this pull request as ready for review June 21, 2023 18:54
@kccain kccain requested a review from a team June 23, 2023 02:47
@mchaarawi mchaarawi merged commit 0c2e1db into master Jun 23, 2023
20 checks passed
@mchaarawi mchaarawi deleted the kccain/daos_13786_cid1444801 branch June 23, 2023 13:13
kccain added a commit that referenced this pull request Jun 23, 2023
@kccain
DAOS-13786 client: pool_free take rdlock for dp_co_list check (#12469)
39ca963 
Fix for Coverity CID 1444801

Signed-off-by: Kenneth Cain <kenneth.c.cain@intel.com>
mchaarawi pushed a commit that referenced this pull request Jun 23, 2023
@kccain
DAOS-13786 client: pool_free take rdlock for dp_co_list check (#12469) (
8adf1a9 
#12473)

Fix for Coverity CID 1444801

Signed-off-by: Kenneth Cain <kenneth.c.cain@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daosbuild1 daosbuild1 daosbuild1 left review comments

@mchaarawi mchaarawi mchaarawi approved these changes

@jolivier23 jolivier23 jolivier23 approved these changes

Assignees
No one assigned
Labels
priority Ticket has high priority (automatically managed) release-2.4 PR is eventually targeted for 2.4
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kccain @mchaarawi @jolivier23 @daosbuild1