Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-13175 dfs: print progress of dfs mwc checker #12470

Merged
merged 1 commit into from
Jun 26, 2023
Merged

DAOS-13175 dfs: print progress of dfs mwc checker #12470

merged 1 commit into from
Jun 26, 2023

Conversation

mchaarawi
Copy link
Contributor

Every 30 seconds print how many objects have been scanned in the dfs namespace or marked in the OIT. This informs users that there is some progress being done by the checker and it's not hung in case of a large namespace.

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

daosbuild1
daosbuild1 previously requested changes Jun 21, 2023
View reviewed changes
src/client/dfs/dfs.c Outdated
int rc;

clock_gettime(CLOCK_REALTIME, &current_time);
oit_args->num_scanned ++;
if (current_time.tv_sec - oit_args->start_time >= DFS_ELAPSED_TIME) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (current_time.tv_sec - oit_args->start_time >= DFS_ELAPSED_TIME) {
if (current_time.tv_sec - oit_args->start_time >= DFS_ELAPSED_TIME) {

@daosbuild1
Copy link
Collaborator

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12470/1/execution/node/144/log

@daosbuild1 daosbuild1 dismissed their stale review June 21, 2023 16:13

Updated patch

daosbuild1
daosbuild1 reviewed Jun 21, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@github-actions
Copy link

Bug-tracker data:
Ticket title is 'print some stats as the checker is running to indicate progress being made'
Status is 'Open'
Labels: 'triaged'
https://daosio.atlassian.net/browse/DAOS-13175

@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-12470/2/testReport/

@mchaarawi
DAOS-13175 dfs: print progress of dfs mwc checker
3790bf7 
Every 30 seconds print how many objects have been scanned in the dfs namespace or marked in the OIT. This informs users that there is some progress being done by the checker and it's not hung in case of a large namespace.

Required-githooks: true

Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@intel.com>
daosbuild1
daosbuild1 reviewed Jun 21, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@mchaarawi mchaarawi marked this pull request as ready for review June 22, 2023 15:02
@mchaarawi mchaarawi requested a review from a team as a code owner June 22, 2023 15:02
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12470/3/execution/node/1289/log

@mchaarawi
Copy link
Contributor Author

failures are all the same as https://daosio.atlassian.net/browse/DAOS-13678 and unrelated to this

wangshilong
wangshilong approved these changes Jun 24, 2023
View reviewed changes
src/client/dfs/dfs.c
rc = clock_gettime(CLOCK_REALTIME, &current_time);
if (rc)
return errno;
oit_args->num_scanned ++;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] oit_args->num_scanned++;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure. i can fix that in another coverity PR i have.

@mchaarawi mchaarawi merged commit 0d8d412 into master Jun 26, 2023
14 of 15 checks passed
@mchaarawi mchaarawi deleted the mschaara/mwc_progress branch June 26, 2023 19:45
mchaarawi added a commit that referenced this pull request Jun 27, 2023
@mchaarawi
DAOS-13175 dfs: print progress of dfs mwc checker (#12470)
8dbf721 
Every 30 seconds print how many objects have been scanned in the dfs namespace or marked in the OIT. This informs users that there is some progress being done by the checker and it's not hung in case of a large namespace.

Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@intel.com>
mchaarawi added a commit that referenced this pull request Jun 28, 2023
@mchaarawi
DAOS-13175 dfs: print progress of dfs mwc checker (#12470) (#12541)
7934290 
Every 30 seconds print how many objects have been scanned in the dfs namespace or marked in the OIT. This informs users that there is some progress being done by the checker and it's not hung in case of a large namespace.

Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daosbuild1 daosbuild1 daosbuild1 left review comments

@wangshilong wangshilong wangshilong approved these changes

@daltonbohning daltonbohning daltonbohning approved these changes

@liuxuezhao liuxuezhao Awaiting requested review from liuxuezhao

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mchaarawi @daosbuild1 @wangshilong @daltonbohning