Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-13684 test: Bump docker nlt system_ram_reserved (#12432) #12471

Merged
merged 1 commit into from
Jun 23, 2023
Merged

DAOS-13684 test: Bump docker nlt system_ram_reserved (#12432) #12471

merged 1 commit into from
Jun 23, 2023

Conversation

tanabarr
Copy link
Contributor

@tanabarr tanabarr commented Jun 21, 2023 •
edited
Loading

Increase system RAM reservation when calculating tmpfs size in NLT
docker tests to avoid intermittent available memory check failures on
engine start due to memory contention across multiple containers on
the same host.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@tanabarr
DAOS-13684 test: Bump docker nlt system_ram_reserved (#12432)
41d747e 
Increase system RAM reservation when calculating tmpfs size in NLT
docker tests to avoid intermittent available memory check failures on
engine start due to memory contention across multiple containers on
the same host.

Signed-off-by: Tom Nabarro <tom.nabarro@intel.com>
@tanabarr tanabarr added the clean-cherry-pick Cherry-pick from another branch that did not require additional edits label Jun 21, 2023
@tanabarr tanabarr self-assigned this Jun 21, 2023
daosbuild1
daosbuild1 reviewed Jun 21, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@github-actions
Copy link

Bug-tracker data:
Ticket title is 'checking MemAvailable (138 GiB) covers at least 90% of engine ram-disks (140 GiB required to cover 155 GiB ram-disk mem): available mem too low to support ramdisk size in FI testing on EL8'
Status is 'Awaiting backport'
Labels: 'triaged'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-13684

@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Jun 21, 2023
@tanabarr tanabarr requested a review from a team June 23, 2023 10:12
@mjmac mjmac merged commit 4f3a3d6 into release/2.4 Jun 23, 2023
16 checks passed
@mjmac mjmac deleted the tanabarr/test-nlt-bump-sysrsvd-rel2_4 branch June 23, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daosbuild1 daosbuild1 daosbuild1 left review comments

@kjacque kjacque kjacque approved these changes

@knard-intel knard-intel knard-intel approved these changes

@mjmac mjmac Awaiting requested review from mjmac

Assignees

@tanabarr tanabarr

Labels
clean-cherry-pick Cherry-pick from another branch that did not require additional edits priority Ticket has high priority (automatically managed)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tanabarr @kjacque @daosbuild1 @knard-intel @mjmac