Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-13785 gurt: protect d_log_refcount with d_log_lock #12474

Merged
merged 1 commit into from
Jun 23, 2023
Merged

DAOS-13785 gurt: protect d_log_refcount with d_log_lock #12474

merged 1 commit into from
Jun 23, 2023

Conversation

kccain
Copy link
Contributor

@kccain kccain commented Jun 21, 2023 •
edited
Loading

Cherry pick to release/2.4 branch, Coverity fix for CID 1443180

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@kccain kccain added the clean-cherry-pick Cherry-pick from another branch that did not require additional edits label Jun 21, 2023
daosbuild1
daosbuild1 reviewed Jun 21, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.4 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12474/1/execution/node/362/log

@github-actions
Copy link

github-actions bot commented Jun 21, 2023 •
edited
Loading

Bug-tracker data:
Ticket title is '[coverity] 1443180 Data race condition'
Status is 'In Progress'
Labels: 'coverity,required_for_code_freeze'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-13785

@github-actions github-actions bot added the release-2.4 PR is eventually targeted for 2.4 label Jun 21, 2023
@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.4 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12474/2/execution/node/197/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12474/2/execution/node/250/log

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12474/2/execution/node/275/log

@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-12474/2/display/redirect

daosbuild1
daosbuild1 reviewed Jun 21, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.4 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12474/3/execution/node/349/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12474/3/execution/node/342/log

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12474/3/execution/node/343/log

@kccain kccain marked this pull request as ready for review June 23, 2023 14:08
@kccain kccain requested review from a team as code owners June 23, 2023 14:08
@kccain kccain requested review from mjmac and a team and removed request for a team June 23, 2023 14:08
@github-actions github-actions bot added priority Ticket has high priority (automatically managed) labels Jun 23, 2023
@kccain
Copy link
Contributor Author

kccain commented Jun 23, 2023

Suggesting direct review by daos-gatekeeper since this is a clean cherry-pick of master commit dc5bbd4 PR 12467, and has no test failures

@mchaarawi
Copy link
Contributor

something is wrong with this cherry-pick. it updated copyright on files that were not touched on this PR or the master one. can you please fix?

@mchaarawi mchaarawi removed the request for review from a team June 23, 2023 14:11
@kccain
Copy link
Contributor Author

kccain commented Jun 23, 2023

@mchaarawi ah yes I just noticed the same thing. Very unepected. I'll try to fix it up.

@kccain
DAOS-13785 gurt: protect d_log_refcount with d_log_lock (#12467)
9c9acbe 
Coverity fix for CID 1443180

Signed-off-by: Kenneth Cain <kenneth.c.cain@intel.com>
@kccain kccain force-pushed the kccain/daos_13785_cid1443180_rel2p4 branch from 6a56c3c to 9c9acbe Compare June 23, 2023 14:36
daosbuild1
daosbuild1 reviewed Jun 23, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@kccain kccain requested a review from a team June 23, 2023 14:39
@kccain
Copy link
Contributor Author

kccain commented Jun 23, 2023

@mchaarawi fixed so the patch has just the single modified file, and added gatekeeper back as you suggested a force landing can be done, to leverage the prior testing with that code change.

@mchaarawi mchaarawi merged commit ee8ce11 into release/2.4 Jun 23, 2023
14 checks passed
@mchaarawi mchaarawi deleted the kccain/daos_13785_cid1443180_rel2p4 branch June 23, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daosbuild1 daosbuild1 daosbuild1 left review comments

@mchaarawi mchaarawi mchaarawi approved these changes

@mjmac mjmac Awaiting requested review from mjmac mjmac was automatically assigned from daos-stack/go-watchers

Assignees
No one assigned
Labels
clean-cherry-pick Cherry-pick from another branch that did not require additional edits priority Ticket has high priority (automatically managed) release-2.4 PR is eventually targeted for 2.4
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kccain @daosbuild1 @mchaarawi