Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-13720 common: Check return code for negative value (#12416) #12477

Merged
merged 1 commit into from
Jun 23, 2023
Merged

DAOS-13720 common: Check return code for negative value (#12416) #12477

merged 1 commit into from
Jun 23, 2023

Conversation

kjacque
Copy link
Contributor

@kjacque kjacque commented Jun 21, 2023 •
edited
Loading

The daos_acl_size function could return an error, although the test expects to succeed.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@kjacque
DAOS-13720 common: Check return code for negative value (#12416)
c8f08b8 
The daos_acl_size function could return an error, although the
test expects to succeed.

Signed-off-by: Kris Jacque <kris.jacque@intel.com>
@kjacque kjacque added the clean-cherry-pick Cherry-pick from another branch that did not require additional edits label Jun 21, 2023
@kjacque kjacque self-assigned this Jun 21, 2023
@kjacque
Copy link
Contributor Author

kjacque commented Jun 21, 2023

This PR only affects a unit test, which will be run with the usual PR tags. No additional test tags are needed.

daosbuild1
daosbuild1 reviewed Jun 21, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.4 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12477/1/execution/node/323/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12477/1/execution/node/317/log

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12477/1/execution/node/322/log

@github-actions
Copy link

github-actions bot commented Jun 21, 2023 •
edited
Loading

Bug-tracker data:
Ticket title is '[coverity] 1426647 Improper use of negative value'
Status is 'Awaiting backport'
Labels: 'coverity,required_for_code_freeze,triaged'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-13720

@github-actions github-actions bot added priority Ticket has high priority (automatically managed) release-2.4 PR is eventually targeted for 2.4 labels Jun 21, 2023
@kjacque kjacque requested a review from a team June 23, 2023 18:38
@mjmac mjmac merged commit 1bc16b3 into release/2.4 Jun 23, 2023
@mjmac mjmac deleted the kjacque/2.4/coverity-1426647 branch June 23, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daosbuild1 daosbuild1 daosbuild1 left review comments

@knard-intel knard-intel knard-intel approved these changes

@tanabarr tanabarr tanabarr approved these changes

@mjmac mjmac mjmac approved these changes

Assignees

@kjacque kjacque

Labels
clean-cherry-pick Cherry-pick from another branch that did not require additional edits priority Ticket has high priority (automatically managed) release-2.4 PR is eventually targeted for 2.4
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kjacque @daosbuild1 @mjmac @tanabarr @knard-intel