Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-9249 test: tag vm tests with vm tag (#12431) #12532

Merged
merged 2 commits into from
Jul 13, 2023
Merged

DAOS-9249 test: tag vm tests with vm tag (#12431) #12532

merged 2 commits into from
Jul 13, 2023

Conversation

daltonbohning
Copy link
Contributor

Test-tag: CartCoRpcFiveNodeTest CartCoRpcOneNodeTest CartCoRpcTwoNodeTest CartCtlFiveNodeTest CartCtlOneNodeTest CartGhostRankRpcOneNodeTest CartGroupTest CartIvOneNodeTest CartIvTwoNodeTest CartNoPmixOneNodeTest CartNoPmixLauncherOneNodeTest CartMultisendOneNodeTest CartRpcOneNodeTest CartRpcTwoNodeTest CartRpcOneNodeSwimNotificationOnRankEvictionTest CartSelfThreeNodeTest CsumContainerValidation HarnessBasicTest HarnessUnitTest

Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test: true

Explicitly tag all VM tests with the "vm" tag.

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@daltonbohning
DAOS-9249 test: tag vm tests with vm tag (#12431)
1645f91 
Test-tag: CartCoRpcFiveNodeTest CartCoRpcOneNodeTest CartCoRpcTwoNodeTest CartCtlFiveNodeTest CartCtlOneNodeTest CartGhostRankRpcOneNodeTest CartGroupTest CartIvOneNodeTest CartIvTwoNodeTest CartNoPmixOneNodeTest CartNoPmixLauncherOneNodeTest CartMultisendOneNodeTest CartRpcOneNodeTest CartRpcTwoNodeTest CartRpcOneNodeSwimNotificationOnRankEvictionTest CartSelfThreeNodeTest CsumContainerValidation HarnessBasicTest HarnessUnitTest

Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test: true

Explicitly tag all VM tests with the "vm" tag.

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
@daltonbohning daltonbohning added the clean-cherry-pick Cherry-pick from another branch that did not require additional edits label Jun 26, 2023
@daltonbohning daltonbohning self-assigned this Jun 26, 2023
daosbuild1
daosbuild1 reviewed Jun 26, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@github-actions
Copy link

Bug-tracker data:
Ticket title is 'Explicitly tag non-hardware functional tests with vm'
Status is 'Awaiting backport'
Labels: 'test_infra'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-9249

@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Jun 26, 2023
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12532/1/execution/node/727/log

@daltonbohning daltonbohning requested a review from a team June 26, 2023 22:24
@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Jun 26, 2023
@daltonbohning
Copy link
Contributor Author

2 failures are expected, since the goal of that test is to manually verify failure behavior:
https://build.hpdd.intel.com/blue/organizations/jenkins/daos-stack%2Fdaos/detail/PR-12532/1/tests

@daltonbohning daltonbohning marked this pull request as ready for review June 26, 2023 22:25
@daltonbohning daltonbohning requested a review from a team as a code owner June 26, 2023 22:25
@daltonbohning
Merge remote-tracking branch 'origin/release/2.4' into dbohning/daos-…
a2acb94 
…9249-2.4

Test-tag: CartCoRpcFiveNodeTest CartCoRpcOneNodeTest CartCoRpcTwoNodeTest CartCtlFiveNodeTest CartCtlOneNodeTest CartGhostRankRpcOneNodeTest CartGroupTest CartIvOneNodeTest CartIvTwoNodeTest CartNoPmixOneNodeTest CartNoPmixLauncherOneNodeTest CartMultisendOneNodeTest CartRpcOneNodeTest CartRpcTwoNodeTest CartRpcOneNodeSwimNotificationOnRankEvictionTest CartSelfThreeNodeTest CsumContainerValidation HarnessBasicTest HarnessUnitTest

Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test: true
daosbuild1
daosbuild1 reviewed Jul 10, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12532/2/execution/node/725/log

@daltonbohning
Copy link
Contributor Author

2 failures are expected, since the goal of that test is to manually verify failure behavior:
https://build.hpdd.intel.com/blue/organizations/jenkins/daos-stack%2Fdaos/detail/PR-12532/2/tests

@phender phender merged commit 70f5d17 into release/2.4 Jul 13, 2023
@phender phender deleted the dbohning/daos-9249-2.4 branch July 13, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daosbuild1 daosbuild1 daosbuild1 left review comments

Assignees

@daltonbohning daltonbohning

Labels
clean-cherry-pick Cherry-pick from another branch that did not require additional edits forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. priority Ticket has high priority (automatically managed)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daltonbohning @daosbuild1 @phender