Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-13763 control: Fix daos_metrics collection for support collect-log. #12555

Merged
merged 2 commits into from
Jul 13, 2023
Merged

DAOS-13763 control: Fix daos_metrics collection for support collect-log. #12555

merged 2 commits into from
Jul 13, 2023

Conversation

ravalsam
Copy link
Contributor

  • Fixed the daos_metrics collection, so it will collect the log for any running engine.
  • Removed the --target-host option and instead AdminNode will be used for doing RSync.

Test-tag: pr support

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@ravalsam
DAOS-13763 control: Fix daos_metrics collection for support collect-log.
933c7a4 
- Fixed the daos_metrics collection so it will collect for any running engine.
- Removed the --target-host option and instead AdminNode will be used for doing RSync.

Test-tag: pr support

Required-githooks: true

Signed-off-by: Samir Raval <samir.raval@intel.com>
@ravalsam ravalsam requested a review from a team as a code owner June 28, 2023 18:25
@ravalsam ravalsam requested review from mjmac and removed request for a team June 28, 2023 18:25
daosbuild1
daosbuild1 reviewed Jun 28, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@github-actions
Copy link

github-actions bot commented Jun 28, 2023 •
edited
Loading

Bug-tracker data:
Ticket title is 'daos_server support collect-log should collect the daos_metrics of running engine in case other engine is dead'
Status is 'In Review'
Labels: 'triaged'
https://daosio.atlassian.net/browse/DAOS-13763

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12555/1/execution/node/1270/log

@ravalsam
Copy link
Contributor Author

Test failures are because of existing issue DAOS-13874 and nothing related to this PR.

knard-intel
knard-intel approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@knard-intel knard-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ravalsam ravalsam requested a review from a team June 30, 2023 15:50
@ravalsam ravalsam added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Jun 30, 2023
daosbuild1
daosbuild1 reviewed Jul 6, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

daosbuild1
daosbuild1 reviewed Jul 7, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12555/4/execution/node/1286/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12555/4/execution/node/1241/log

mchaarawi
mchaarawi reviewed Jul 10, 2023
View reviewed changes
Copy link
Contributor

@mchaarawi mchaarawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr is still running. removing gatekeeper request

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12555/5/execution/node/381/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-12555/5/testReport/

@ravalsam
Copy link
Contributor Author

Few tests are because of existing defect DAOS-13914 DAOS-13582 and not related to this PR.

@ravalsam ravalsam requested a review from a team July 10, 2023 20:08
@mchaarawi mchaarawi merged commit a73b2c4 into master Jul 13, 2023
15 checks passed
@mchaarawi mchaarawi deleted the samirrav/support/DAOS-13763 branch July 13, 2023 14:25
cdavis28 added a commit that referenced this pull request May 20, 2024
@cdavis28
b/340244046 initial port collect command from master to 2.4
fe6a957 
Although this port copies the code from master to 2.4, there
are issues related to permissions making it non-functional.

This is a partial cherry-pick of the following PR's on master:
DAOS-10625 control: Create the tool to collect the logs/config for support purpose (#11094)
DAOS-13759 control: Update support collect-log tool. (#12906)
DAOS-13763 control: Fix daos_metrics collection for support collect-log. (#12555)
DAOS-13936 support: Collect the specific logs and Time range log for support (#13325)

Change-Id: I168c14e177a5003c4e315595b1bf154e84cef473
cdavis28 added a commit that referenced this pull request May 20, 2024
@cdavis28
b/340244046 initial port collect command from master to 2.4
2913a20 
Although this port copies the code from master to 2.4, there
are issues related to permissions making it non-functional.

This is a partial cherry-pick of the following PR's on master:
DAOS-10625 control: Create the tool to collect the logs/config for support purpose (#11094)
DAOS-13759 control: Update support collect-log tool. (#12906)
DAOS-13763 control: Fix daos_metrics collection for support collect-log. (#12555)
DAOS-13936 support: Collect the specific logs and Time range log for support (#13325)

Change-Id: I168c14e177a5003c4e315595b1bf154e84cef473
cdavis28 added a commit that referenced this pull request May 20, 2024
@cdavis28
b/340244046 initial port collect command from master to 2.4
746ce35 
Although this port copies the code from master to 2.4, there
are issues related to permissions making it non-functional.

This is a partial cherry-pick of the following PR's on master:
DAOS-10625 control: Create the tool to collect the logs/config for support purpose (#11094)
DAOS-13759 control: Update support collect-log tool. (#12906)
DAOS-13763 control: Fix daos_metrics collection for support collect-log. (#12555)
DAOS-13936 support: Collect the specific logs and Time range log for support (#13325)

Change-Id: I168c14e177a5003c4e315595b1bf154e84cef473
cdavis28 added a commit that referenced this pull request May 20, 2024
@cdavis28
b/340244046 initial port collect command from master to 2.4
b9bdc26 
Although this port copies the code from master to 2.4, there
are issues related to permissions making it non-functional.

This is a partial cherry-pick of the following PR's on master:
DAOS-10625 control: Create the tool to collect the logs/config for support purpose (#11094)
DAOS-13759 control: Update support collect-log tool. (#12906)
DAOS-13763 control: Fix daos_metrics collection for support collect-log. (#12555)
DAOS-13936 support: Collect the specific logs and Time range log for support (#13325)

Signed-off-by: Chris Davis <chrd@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchaarawi mchaarawi mchaarawi left review comments

@daosbuild1 daosbuild1 daosbuild1 left review comments

@tanabarr tanabarr tanabarr approved these changes

@kjacque kjacque kjacque approved these changes

@knard-intel knard-intel knard-intel approved these changes

@mjmac mjmac Awaiting requested review from mjmac mjmac is a code owner automatically assigned from daos-stack/go-watchers

Assignees
No one assigned
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ravalsam @daosbuild1 @tanabarr @mchaarawi @kjacque @knard-intel