DAOS-13886 test: Fix system name validation #12570

knard-intel · 2023-07-03T08:13:23Z

Description

Fix test regression with system name introduce with PR #12509:

Fix regression introduce with PR #12508: issue with dmg and configuration files parsing.

Miscellaneous small improvements of the src/tests/ftest/control/version.py test.

Validation

Test-tag is used to limit the tests to the functional ones updated by this PR.

Before requesting gatekeeper:

Two review approvals and any prior change requests have been resolved.
Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
Commit messages follows the guidelines outlined here.
Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

github-actions · 2023-07-03T08:13:45Z

Bug-tracker data:
Ticket title is 'control/daos_agent_config.py:DaosAgentConfigTest.test_daos_agent_config_basic - '
Status is 'In Review'
Labels: 'ci_impact,daily_test,triaged'
https://daosio.atlassian.net/browse/DAOS-13886

daosbuild1

LGTM. No errors found by checkpatch.

daosbuild1 · 2023-07-03T11:29:11Z

Test stage Functional on EL 8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-12570/1/testReport/

daosbuild1

LGTM. No errors found by checkpatch.

daosbuild1

LGTM. No errors found by checkpatch.

daosbuild1

LGTM. No errors found by checkpatch.

daosbuild1

LGTM. No errors found by checkpatch.

daosbuild1 · 2023-07-04T10:49:48Z

Test stage Functional on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12570/5/execution/node/1097/log

daosbuild1

LGTM. No errors found by checkpatch.

daosbuild1 · 2023-07-04T12:26:13Z

Test stage Functional on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12570/6/execution/node/1097/log

daosbuild1

LGTM. No errors found by checkpatch.

daosbuild1 · 2023-07-04T14:06:54Z

Test stage Functional on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12570/7/execution/node/1097/log

daosbuild1

LGTM. No errors found by checkpatch.

…/daos-13886 Features: control Required-githooks: true

daosbuild1

LGTM. No errors found by checkpatch.

knard-intel · 2023-07-07T17:55:51Z

Restart CI build as it was stuck in functional HW test with the wolf network issue.
However, the VM functional tests were all passed with the last fix :)

daosbuild1

LGTM. No errors found by checkpatch.

daosbuild1 · 2023-07-10T21:15:28Z

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12570/19/execution/node/1242/log

daosbuild1

LGTM. No errors found by checkpatch.

tanabarr · 2023-07-11T12:09:13Z

src/tests/ftest/control/daos_control_config.yaml

@@ -33,7 +33,7 @@ control_config_val: !mux
 config_val:
 - "name"
 - "! @#$%^&*()_+{}|:<>?-=[];',./"
- - "PASS"
+ - "FAIL"


We should expand the coverage to cover special characters and over length, the reason this now fails is because there is a new length requirement introduced by 0b5cdc0 which limits to 15 chars.

I suggest reducing the value in this test case to 15 chars (which should pass even with special characters) and leaving the expectation as "PASS". Then add another name_links_exceeded test case with the original value which should result in a failure.

I agree that would be better.

I agree that would be better.

@tanabarr pushed the commit ce83191 to update the unit tests in this way 😸

daosbuild1

LGTM. No errors found by checkpatch.

Features: control Required-githooks: true Signed-off-by: Tom Nabarro <tom.nabarro@intel.com>

daosbuild1

LGTM. No errors found by checkpatch.

phender · 2023-07-11T19:05:32Z

src/tests/ftest/control/version.py

+ # Remove configuration files
+ cleanup_cmds = [
+ "sudo find /etc/daos/certs -type f -delete -print",
+ "sudo rm -fv /etc/daos/daos_server.yml /etc/daos/daos_control.yml"
+ " /etc/daos/daos_agent.yml",
+ ]
+ for cmd in cleanup_cmds:
+ run_pcmd(hosts=self.hostlist_servers, command=cmd)


If we need to run this test w/o certificates, the preferred method is to use the following test yaml entries:

server_config: transport_config: allow_insecure: true agent_config: transport_config: allow_insecure: true dmg: transport_config: allow_insecure: true

I will add these config parameters in a follow up PR as this one has been already merged.
Otherwise, I would prefer to keep the cleanup cmds as it seems that the /etc/daos is not properly cleanned between test runs.

Add insecure yaml config

Fixed with PR #12615

phender · 2023-07-12T12:47:51Z

src/tests/ftest/control/version.py

 # Don't waste time starting servers and agents.
 self.setup_start_servers = False
 self.setup_start_agents = False

+ self.errors = []
+
+ def report_result(self):


The tearDown() and setUp() methods provide markers to help find the beginning and end of the test - a sequence of 80 = characters. We typically just end each test_* method with self.log.info("Test passed") to indicate test passing (in addition to avocado's own messaging) and rely on self.fail() or assertions to indicate the test failure before calling tearDown(). If we need more than this it should be standardized so we can use the same search string for all test job.log results. That said, it can be addressed in a different PR.

In fact, I have done it this way, to keep the same behavior as it was originally done in the PR.
However, if there is some standard to respect I will fix this in a follow up PR as this one has been already merged.

Use standardized test result message

Fixed with PR #12615

daosbuild1 reviewed Jul 3, 2023

View reviewed changes

knard-intel force-pushed the ckochhof/fix/master/daos-13886 branch from 9fc7233 to 571e013 Compare July 3, 2023 13:09

daosbuild1 reviewed Jul 3, 2023

View reviewed changes

knard-intel force-pushed the ckochhof/fix/master/daos-13886 branch from 571e013 to 2ac3633 Compare July 3, 2023 13:11

daosbuild1 reviewed Jul 3, 2023

View reviewed changes

knard-intel mentioned this pull request Jul 3, 2023

DAOS-13471 control: Add JSON-format version to utilities #12508

Merged

knard-intel force-pushed the ckochhof/fix/master/daos-13886 branch from 2ac3633 to 9790013 Compare July 4, 2023 09:04

daosbuild1 reviewed Jul 4, 2023

View reviewed changes

knard-intel force-pushed the ckochhof/fix/master/daos-13886 branch from 9790013 to 5601fae Compare July 4, 2023 09:24

daosbuild1 reviewed Jul 4, 2023

View reviewed changes

knard-intel requested review from mjmac, shimizukko and daltonbohning July 4, 2023 10:40

knard-intel marked this pull request as ready for review July 4, 2023 10:40

knard-intel requested a review from a team as a code owner July 4, 2023 10:40

knard-intel removed request for mjmac, shimizukko and daltonbohning July 4, 2023 10:52

knard-intel force-pushed the ckochhof/fix/master/daos-13886 branch from 5601fae to eed5046 Compare July 4, 2023 11:00

daosbuild1 reviewed Jul 4, 2023

View reviewed changes

knard-intel force-pushed the ckochhof/fix/master/daos-13886 branch from eed5046 to f84e1d5 Compare July 4, 2023 12:38

daosbuild1 reviewed Jul 4, 2023

View reviewed changes

knard-intel force-pushed the ckochhof/fix/master/daos-13886 branch from f84e1d5 to b17991f Compare July 4, 2023 14:17

daosbuild1 reviewed Jul 4, 2023

View reviewed changes

knard-intel force-pushed the ckochhof/fix/master/daos-13886 branch from b17991f to 3041157 Compare July 4, 2023 14:26

knard-intel requested review from mjmac and shimizukko July 7, 2023 17:36

Merge remote-tracking branch 'origin/master' into ckochhof/fix/master…

c94bb40

…/daos-13886 Features: control Required-githooks: true

daosbuild1 reviewed Jul 7, 2023

View reviewed changes

shimizukko previously approved these changes Jul 7, 2023

View reviewed changes

daosbuild1 reviewed Jul 10, 2023

View reviewed changes

knard-intel requested review from tanabarr and kjacque July 10, 2023 19:45

mjmac previously approved these changes Jul 10, 2023

View reviewed changes

daosbuild1 reviewed Jul 11, 2023

View reviewed changes

tanabarr reviewed Jul 11, 2023

View reviewed changes

tanabarr dismissed stale reviews from mjmac and shimizukko via 3ba1ce2 July 11, 2023 12:24

tanabarr self-requested a review July 11, 2023 12:25

tanabarr approved these changes Jul 11, 2023

View reviewed changes

daosbuild1 reviewed Jul 11, 2023

View reviewed changes

add coverage for length exceeded as well as special characters

ce83191

Features: control Required-githooks: true Signed-off-by: Tom Nabarro <tom.nabarro@intel.com>

tanabarr force-pushed the ckochhof/fix/master/daos-13886 branch from 3ba1ce2 to ce83191 Compare July 11, 2023 12:27

knard-intel requested review from mjmac and shimizukko July 11, 2023 12:28

daosbuild1 reviewed Jul 11, 2023

View reviewed changes

kjacque approved these changes Jul 11, 2023

View reviewed changes

shimizukko approved these changes Jul 11, 2023

View reviewed changes

knard-intel requested a review from a team July 12, 2023 05:58

mchaarawi merged commit 34552ff into master Jul 12, 2023
21 checks passed

mchaarawi deleted the ckochhof/fix/master/daos-13886 branch July 12, 2023 12:38

phender reviewed Jul 12, 2023

View reviewed changes

knard-intel mentioned this pull request Jul 13, 2023

DAOS-13886 test: Fix version functional test #12615

Merged

18 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DAOS-13886 test: Fix system name validation #12570

DAOS-13886 test: Fix system name validation #12570

knard-intel commented Jul 3, 2023 •

edited

Loading

github-actions bot commented Jul 3, 2023 •

edited

Loading

daosbuild1 left a comment

daosbuild1 commented Jul 3, 2023

daosbuild1 left a comment

daosbuild1 left a comment

daosbuild1 left a comment

daosbuild1 left a comment

daosbuild1 commented Jul 4, 2023

daosbuild1 left a comment

daosbuild1 commented Jul 4, 2023

daosbuild1 left a comment

daosbuild1 commented Jul 4, 2023

daosbuild1 left a comment

daosbuild1 left a comment

knard-intel commented Jul 7, 2023 •

edited

Loading

daosbuild1 left a comment

daosbuild1 commented Jul 10, 2023

daosbuild1 left a comment

tanabarr Jul 11, 2023

ashleypittman Jul 12, 2023

knard-intel Jul 12, 2023

daosbuild1 left a comment

daosbuild1 left a comment

phender Jul 11, 2023

knard-intel Jul 12, 2023 •

edited

Loading

knard-intel Jul 13, 2023 •

edited

Loading

phender Jul 12, 2023

knard-intel Jul 12, 2023 •

edited

Loading

knard-intel Jul 13, 2023

DAOS-13886 test: Fix system name validation #12570

DAOS-13886 test: Fix system name validation #12570

Conversation

knard-intel commented Jul 3, 2023 • edited Loading

Description

Validation

Before requesting gatekeeper:

Gatekeeper:

github-actions bot commented Jul 3, 2023 • edited Loading

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 commented Jul 3, 2023

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 commented Jul 4, 2023

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 commented Jul 4, 2023

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 commented Jul 4, 2023

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 left a comment

Choose a reason for hiding this comment

knard-intel commented Jul 7, 2023 • edited Loading

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 commented Jul 10, 2023

daosbuild1 left a comment

Choose a reason for hiding this comment

tanabarr Jul 11, 2023

Choose a reason for hiding this comment

ashleypittman Jul 12, 2023

Choose a reason for hiding this comment

knard-intel Jul 12, 2023

Choose a reason for hiding this comment

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 left a comment

Choose a reason for hiding this comment

phender Jul 11, 2023

Choose a reason for hiding this comment

knard-intel Jul 12, 2023 • edited Loading

Choose a reason for hiding this comment

knard-intel Jul 13, 2023 • edited Loading

Choose a reason for hiding this comment

phender Jul 12, 2023

Choose a reason for hiding this comment

knard-intel Jul 12, 2023 • edited Loading

Choose a reason for hiding this comment

knard-intel Jul 13, 2023

Choose a reason for hiding this comment

knard-intel commented Jul 3, 2023 •

edited

Loading

github-actions bot commented Jul 3, 2023 •

edited

Loading

knard-intel commented Jul 7, 2023 •

edited

Loading

knard-intel Jul 12, 2023 •

edited

Loading

knard-intel Jul 13, 2023 •

edited

Loading

knard-intel Jul 12, 2023 •

edited

Loading