Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-13907 kv: allow users to insert keys with empty values #12590

Merged
merged 2 commits into from
Jul 10, 2023

Conversation

mchaarawi
Copy link
Contributor

  • also fix some potential double free on error path

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

- also fix some potential double free on error path

Required-githooks: true

Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@intel.com>
@github-actions
Copy link

github-actions bot commented Jul 7, 2023

Bug-tracker data:

@github-actions github-actions bot added priority Ticket has high priority (automatically managed) release-2.4 PR is eventually targeted for 2.4 labels Jul 7, 2023
@mchaarawi mchaarawi marked this pull request as ready for review July 7, 2023 13:41
@mchaarawi mchaarawi requested a review from a team as a code owner July 7, 2023 13:41
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@mchaarawi mchaarawi merged commit 61e2eb6 into master Jul 10, 2023
13 of 15 checks passed
@mchaarawi mchaarawi deleted the mschaara/kv_no_value branch July 10, 2023 13:25
mchaarawi added a commit that referenced this pull request Jul 11, 2023
- also fix some potential double free on error path

Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@intel.com>
mchaarawi added a commit that referenced this pull request Jul 13, 2023
…12609)

- also fix some potential double free on error path

Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority Ticket has high priority (automatically managed) release-2.4 PR is eventually targeted for 2.4
Development

Successfully merging this pull request may close these issues.

5 participants