Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-13670 control: Add system name validation on startup #12644

Merged
merged 1 commit into from
Jul 25, 2023
Merged

DAOS-13670 control: Add system name validation on startup #12644

merged 1 commit into from
Jul 25, 2023

Conversation

knard-intel
Copy link
Contributor

@knard-intel knard-intel commented Jul 15, 2023 •
edited by tanabarr
Loading

Description

Explicitly check the configured system name and fail if it does not meet requirements.
Miscellaneous small improvements of the src/tests/ftest/control/version.py test.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@github-actions
Copy link

Bug-tracker data:
Ticket title is 'server/daos_server_config.py:DaosServerConfigTest.test_daos_server_config_basic - request system does not match running system'
Status is 'Resolved'
Labels: 'ci_impact,daily_test,triaged'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-13670

@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Jul 15, 2023
@knard-intel knard-intel changed the title DAOS-13670 control: Add system name validation on startup (#12509) DAOS-13670 control: Add system name validation on startup Jul 15, 2023
daosbuild1
daosbuild1 reviewed Jul 15, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@knard-intel knard-intel self-assigned this Jul 15, 2023
@knard-intel knard-intel added control-plane work on the management infrastructure of the DAOS Control Plane unclean-cherry-pick Indicates that a cherry-pick had merge conflicts that needed resolving. release-2.4 PR is eventually targeted for 2.4 labels Jul 15, 2023
daosbuild1
daosbuild1 reviewed Jul 15, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12644/2/execution/node/1097/log

@knard-intel
Copy link
Contributor Author

PR will fail until PR #12544 has been landed within release 2.4 branch.

@github-actions github-actions bot removed the release-2.4 PR is eventually targeted for 2.4 label Jul 19, 2023
daosbuild1
daosbuild1 reviewed Jul 19, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12644/3/execution/node/1259/log

@mjmac @knard-intel
DAOS-13670 control: Add system name validation on startup
60db2cd 
Explicitly check the configured system name and fail if
it does not meet requirements.

Miscellaneous small improvements of the src/tests/ftest/control/version.py test.

Features: control
Required-githooks: true

Signed-off-by: Michael MacDonald <mjmac.macdonald@intel.com>
Signed-off-by: Tom Nabarro <tom.nabarro@intel.com>
Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@intel.com>
daosbuild1
daosbuild1 reviewed Jul 20, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12644/4/execution/node/1096/log

daosbuild1
daosbuild1 reviewed Jul 20, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12644/5/execution/node/1241/log

@knard-intel
Copy link
Contributor Author

The last PR build 5 failed on one known issue:

@knard-intel knard-intel marked this pull request as ready for review July 21, 2023 06:00
@knard-intel knard-intel requested review from a team as code owners July 21, 2023 06:00
@knard-intel knard-intel requested review from mjmac, shimizukko and daltonbohning and removed request for a team July 21, 2023 06:00
@knard-intel knard-intel requested a review from a team July 24, 2023 05:55
tanabarr
tanabarr approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@tanabarr tanabarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only comment I left is minor and should only be addressed if you have to re-push, thanks

src/control/cmd/dmg/main.go
@@ -222,6 +222,12 @@ and access control settings, along with system wide operations.`
logCmd.SetLog(log)
}

switch cmd.(type) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this could probably resolve to a if _, ok := cmd.(*versionCmd) {return...}

@tanabarr tanabarr added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Jul 25, 2023
@tanabarr
Copy link
Contributor

@daos-stack/daos-gatekeeper please could this PR be force landed?

@mchaarawi mchaarawi merged commit 6768d3b into release/2.4 Jul 25, 2023
@mchaarawi mchaarawi deleted the ckochhof/fix/2.4/daos-13886 branch July 25, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daosbuild1 daosbuild1 daosbuild1 left review comments

@kjacque kjacque kjacque approved these changes

@shimizukko shimizukko shimizukko approved these changes

@tanabarr tanabarr tanabarr approved these changes

@mjmac mjmac Awaiting requested review from mjmac mjmac is a code owner automatically assigned from daos-stack/go-watchers

@daltonbohning daltonbohning Awaiting requested review from daltonbohning

Assignees

@knard-intel knard-intel

Labels
control-plane work on the management infrastructure of the DAOS Control Plane forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. priority Ticket has high priority (automatically managed) unclean-cherry-pick Indicates that a cherry-pick had merge conflicts that needed resolving.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@knard-intel @daosbuild1 @tanabarr @shimizukko @kjacque @mchaarawi @mjmac