DAOS-13228 control: List BDEV role assignments in scan/format display #13463

tanabarr · 2023-12-07T23:30:02Z

Add MD-on-SSD bdev role and engine rank assignments to dmg storage
scan. Add role assignments to dmg storage format. Roles will be listed
as NA if MD-on-SSD mode is not enabled. Also show which NVMe namespace
each SMD resides on in dmg storage query list-devices through NSID
(which is useful in the case where NVMe controllers have multiple
namespaces).

Remove dmg storage scan --nvme-meta option as all info is available
through combination of dmg storage scan -v and dmg storage query
list-devices.

Make zero-value LED state N/A so NORMAL is not reported in
uninitialized controller structures.

Skip-func-hw-medium-md-on-ssd: false
Skip-func-hw-medium-verbs-provider-md-on-ssd: false
Skip-func-hw-large-md-on-ssd: false
Features: control
Required-githooks: true

Before requesting gatekeeper:

Two review approvals and any prior change requests have been resolved.
Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
Commit messages follows the guidelines outlined here.
Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

github-actions · 2023-12-07T23:30:19Z

Bug-tracker data:
Ticket title is 'vos_on_blob: dmg storage commands should list bdev_role(s)'
Status is 'In Review'
Labels: 'md_on_ssd,usability'
https://daosio.atlassian.net/browse/DAOS-13228

daosbuild1

LGTM. No errors found by checkpatch.

daosbuild1 · 2023-12-10T13:09:48Z

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13463/1/execution/node/1414/log

daosbuild1 · 2023-12-10T15:08:02Z

Test stage Functional Hardware Medium completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13463/1/testReport/

daosbuild1 · 2023-12-11T05:18:01Z

Test stage Functional Hardware Large completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13463/1/testReport/

knard-intel

The modification of the dmg command seems to break some functional tests, which will probably needed to be updated.

knard-intel · 2023-12-11T08:28:33Z

src/control/cmd/dmg/pretty/storage_nvme.go

+	for _, ctrlr := range parseNvmeFormatResults(ctrlrs) {
+		row := txtfmt.TableRow{pciTitle: ctrlr.PciAddr}
+		row[resultTitle] = ctrlr.Info
+		roles := "???"


Instead of ???, the role data could be used for md-on-scm ?

@Michael-Hennecke for PMem mode I'm displaying N/A for roles Rather than "Data", is that appropriate or should I change?

while the NVMe usage clearly is for "data", the PMem mode doesn't have any roles (and we state for the yml that either all 3 roles or none of them shall be assigned). so for consistency this should probably be empty or "none" or "NULL" or "n/a". But using "???" as the text string seems odd, because there's nothing unknown about this state.

Thanks @Michael-Hennecke , your responses in line with my approach. "???" should never end up being printed, it is simply a placeholder for either "N/A" in PMem mode or roles in MD-on-SSD mode. I didn't want to start with an empty string or "N/A" as the default as neither are useful and both could be confusing. "???" simply implies that it hasn't been set yet and shouldn't end up being displayed to the user.

knard-intel · 2023-12-11T08:28:41Z

src/control/cmd/dmg/pretty/storage_nvme.go

@@ -227,6 +234,12 @@ func PrintNvmeControllers(controllers storage.NvmeControllers, out io.Writer, op
 		row[fwTitle] = ctrlr.FwRev
 		row[socketTitle] = fmt.Sprint(ctrlr.SocketID)
 		row[capacityTitle] = humanize.Bytes(ctrlr.Capacity())
+		roles := "???"


Instead of ???, the role data could be used for md-on-scm ?

knard-intel · 2023-12-11T08:37:36Z

src/control/lib/control/storage.go

@@ -240,7 +239,7 @@ func StorageScan(ctx context.Context, rpcClient UnaryInvoker, req *StorageScanRe
 				Basic: req.NvmeBasic,
 				// Health and meta details required to populate usage statistics.
 				Health: req.NvmeHealth || req.Usage,
-				Meta:   req.NvmeMeta || req.Usage,
+				Meta:   req.Usage,


Do we still need this field to for compatibility reason with the engine.
If yes, is it planned to also remove it from the engine ?

where should it be removed in the engine?

knard-intel · 2023-12-11T08:40:01Z

src/control/server/storage/config.go

@@ -43,6 +43,7 @@ const (
 	accelOptMoveName = "move"
 	accelOptCRCName  = "crc"

+	bdevRoleNoneName = "n/a"


Could it make sense to have the role data instead ?

As per conversation with @Michael-Hennecke , "roles" should only exist in MD-on-SSD mode, so no roles should be described in PMem mode.

daosbuild1

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-13463/2/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

daosbuild1 · 2023-12-12T16:36:07Z

utils/githooks/pre-commit.d/20-Jenkinsfile

+CURL_VERBOSE=${CURL_VERBOSE:-""}
+CURL_PROXY="${CURL_PROXY:+-x }${CURL_PROXY:-}"
+CURL_OPTS="$CURL_PROXY $CURL_VERBOSE -s"
+if ! output=$(curl $CURL_OPTS -s -X POST -F "jenkinsfile=<${1:-Jenkinsfile}" https://$HOST//pipeline-model-converter/validate); then


(lint) Double quote to prevent globbing and word splitting. [SC2086]
(lint) Double quote to prevent globbing and word splitting. [SC2086]

daosbuild1 · 2023-12-12T16:36:09Z

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13463/2/execution/node/156/log

daosbuild1 · 2023-12-12T16:38:42Z

Test stage Build on Leap 15.5 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13463/2/execution/node/403/log

daosbuild1 · 2023-12-12T16:38:55Z

Test stage Build on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13463/2/execution/node/418/log

daosbuild1 · 2023-12-12T16:40:21Z

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13463/2/execution/node/383/log

daosbuild1 · 2023-12-12T16:42:04Z

Test stage Build RPM on Leap 15.5 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13463/2/execution/node/379/log

daosbuild1 · 2023-12-12T16:42:15Z

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13463/2/execution/node/398/log

daosbuild1 · 2023-12-12T16:45:34Z

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13463/2/execution/node/373/log

Updated patch

daosbuild1

LGTM. No errors found by checkpatch.

daosbuild1 · 2023-12-12T20:01:16Z

Test stage Functional on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13463/3/execution/node/1163/log

daosbuild1

LGTM. No errors found by checkpatch.

daosbuild1 · 2023-12-13T20:06:26Z

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13463/5/execution/node/1163/log

daosbuild1

LGTM. No errors found by checkpatch.

mjmac · 2024-01-09T21:48:19Z

Oops, I clicked the wrong thing while distracted, my apologies.

tanabarr · 2024-01-11T11:28:02Z

@daos-stack/daos-gatekeeper can this PR please be force landed?

https://build.hpdd.intel.com/blue/organizations/jenkins/daos-stack%2Fdaos/detail/PR-13463/21/tests/ failed due to the known issues:

daos_test/suite.py daos_rebuild_ec failure - at least one multi-variant server not found in expected state, https://daosio.atlassian.net/browse/DAOS-14598
OSAOnlineDrain failure - https://daosio.atlassian.net/browse/DAOS-14851

…d-roles-to-scan-output Skip-func-hw-medium-md-on-ssd: false Skip-func-hw-medium-verbs-provider-md-on-ssd: false Skip-func-hw-large-md-on-ssd: false Features: control pool Required-githooks: true Signed-off-by: Tom Nabarro <tom.nabarro@intel.com>

daosbuild1 · 2024-01-15T11:30:37Z

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13463/22/execution/node/1463/log

daosbuild1 · 2024-01-15T14:32:20Z

Test stage Functional Hardware Medium completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13463/22/testReport/

tanabarr · 2024-01-15T21:46:04Z

CI results for run no. 22 with control and pool features failed for the following known issues:

Requesting forced landing

NiuYawei

Looks the "tests_dmg_helpers.c" needs be fixed for the json format changes? otherwise, dmg_storage_device_list() used by C testing code will fail.

tanabarr · 2024-01-18T18:31:32Z

Looks the "tests_dmg_helpers.c" needs be fixed for the json format changes? otherwise, dmg_storage_device_list() used by C testing code will fail.

So as to not pollute this PR unnecessarily the fix for that is in #13630 . The issue you refer to is not directly related to this PR.

…d-roles-to-scan-output Skip-func-hw-medium-md-on-ssd: false Skip-func-hw-medium-verbs-provider-md-on-ssd: false Skip-func-hw-large-md-on-ssd: false Features: control Required-githooks: true Signed-off-by: Tom Nabarro <tom.nabarro@intel.com>

tanabarr · 2024-01-22T16:03:17Z

@daos-stack/daos-gatekeeper please can this PR be force landed now landings are open on master?

mchaarawi · 2024-01-22T17:19:36Z

there are 2 failures on this PR that i am not aware of being as known failures:
FTEST_control.DmgSystemReformatTest
FTEST_pool.ListVerboseTest

so this seems not ready to land.

mchaarawi · 2024-01-22T17:21:10Z

there are 2 failures on this PR that i am not aware of being as known failures: FTEST_control.DmgSystemReformatTest FTEST_pool.ListVerboseTest

so this seems not ready to land.

also if you think otherwise, please merge with latest master with the control Feature pragma

tanabarr · 2024-01-22T17:34:54Z

there are 2 failures on this PR that i am not aware of being as known failures: FTEST_control.DmgSystemReformatTest FTEST_pool.ListVerboseTest

so this seems not ready to land.

These are both manifestations of https://daosio.atlassian.net/browse/DAOS-14884 as identified by @knard-intel . As the fix has landed I will merge master and repush.

tanabarr self-assigned this Dec 7, 2023

tanabarr requested review from mjmac, kjacque, Michael-Hennecke and knard-intel December 7, 2023 23:30

daosbuild1 reviewed Dec 7, 2023

View reviewed changes

knard-intel reviewed Dec 11, 2023

View reviewed changes

tanabarr force-pushed the tanabarr/control-add-roles-to-scan-output branch from 4570a8c to 1a8a236 Compare December 12, 2023 16:33

daosbuild1 previously requested changes Dec 12, 2023

View reviewed changes

tanabarr force-pushed the tanabarr/control-add-roles-to-scan-output branch from 1a8a236 to b804a85 Compare December 12, 2023 16:45

daosbuild1 reviewed Dec 12, 2023

View reviewed changes

tanabarr force-pushed the tanabarr/control-add-roles-to-scan-output branch from b804a85 to f80b489 Compare December 13, 2023 17:00

daosbuild1 reviewed Dec 13, 2023

View reviewed changes

tanabarr force-pushed the tanabarr/control-add-roles-to-scan-output branch from f80b489 to a2ddaf2 Compare December 14, 2023 11:29

daosbuild1 reviewed Dec 14, 2023

View reviewed changes

tanabarr force-pushed the tanabarr/control-remove-bdev-scan-cache-pt2-cp branch from 6b7d53a to 46a1b63 Compare December 14, 2023 14:41

mjmac reopened this Jan 9, 2024

mjmac approved these changes Jan 9, 2024

View reviewed changes

tanabarr requested a review from a team January 9, 2024 23:07

tanabarr removed the request for review from a team January 14, 2024 21:07

tanabarr removed the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Jan 14, 2024

tanabarr requested a review from a team January 15, 2024 21:35

tanabarr added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Jan 15, 2024

tanabarr requested review from wangshilong and NiuYawei January 16, 2024 11:01

NiuYawei reviewed Jan 18, 2024

View reviewed changes

tanabarr requested a review from NiuYawei January 18, 2024 18:28

tanabarr requested a review from a team January 18, 2024 18:35

tanabarr added the meta-on-ssd Metadata on SSD Feature label Jan 18, 2024

NiuYawei approved these changes Jan 19, 2024

View reviewed changes

tanabarr removed the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Jan 22, 2024

tanabarr requested a review from a team January 23, 2024 10:10

NiuYawei merged commit 6e20194 into master Jan 23, 2024
51 checks passed

NiuYawei deleted the tanabarr/control-add-roles-to-scan-output branch January 23, 2024 10:48

DAOS-13228 control: List BDEV role assignments in scan/format display #13463

DAOS-13228 control: List BDEV role assignments in scan/format display #13463

Conversation

tanabarr commented Dec 7, 2023 • edited Loading

Before requesting gatekeeper:

Gatekeeper:

github-actions bot commented Dec 7, 2023 • edited Loading

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 commented Dec 10, 2023

daosbuild1 commented Dec 10, 2023

daosbuild1 commented Dec 11, 2023

knard-intel left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Michael-Hennecke Dec 11, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

knard-intel Dec 11, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daosbuild1 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daosbuild1 commented Dec 12, 2023

daosbuild1 commented Dec 12, 2023

daosbuild1 commented Dec 12, 2023

daosbuild1 commented Dec 12, 2023

daosbuild1 commented Dec 12, 2023

daosbuild1 commented Dec 12, 2023

daosbuild1 commented Dec 12, 2023

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 commented Dec 12, 2023

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 commented Dec 13, 2023

daosbuild1 left a comment

Choose a reason for hiding this comment

mjmac commented Jan 9, 2024

tanabarr commented Jan 11, 2024

daosbuild1 commented Jan 15, 2024

daosbuild1 commented Jan 15, 2024

tanabarr commented Jan 15, 2024 • edited Loading

NiuYawei left a comment

Choose a reason for hiding this comment

tanabarr commented Jan 18, 2024 • edited Loading

tanabarr commented Jan 22, 2024

mchaarawi commented Jan 22, 2024

mchaarawi commented Jan 22, 2024

tanabarr commented Jan 22, 2024

tanabarr commented Dec 7, 2023 •

edited

Loading

github-actions bot commented Dec 7, 2023 •

edited

Loading

Michael-Hennecke Dec 11, 2023 •

edited

Loading

knard-intel Dec 11, 2023 •

edited

Loading

tanabarr commented Jan 15, 2024 •

edited

Loading

tanabarr commented Jan 18, 2024 •

edited

Loading