DAOS-15055 tools: Add build host/time to JSON version #13644
Conversation
Include build timestamp in all builds. Only include build host in non-release builds. Change-Id: I2d5525c21da2537a9583e9dbd57265e34639913f Required-githooks: true Signed-off-by: Michael MacDonald <mjmac@google.com>
mjmac
requested review from
tanabarr and
kjacque
and removed request for
a team
|
Bug-tracker data: |
For non-release builds, it's useful for determining the provenance of binaries. If I don't have to guess, I'd rather not. :) |
Change-Id: Iaf92ec13174f2aa6b4625b77dd3195e742773f11 Required-githooks: true Signed-off-by: Michael MacDonald <mjmac@google.com>
Include build timestamp in all builds. Only include build host in non-release builds. Signed-off-by: Michael MacDonald <mjmac@google.com>
| Import('daos_version', 'conf_dir') | ||
| path = 'github.com/daos-stack/daos/src/control/build' | ||
| return ' '.join([f'-X {path}.DaosVersion={daos_version}', | ||
| f'-X {path}.ConfigDir={conf_dir}', | ||
| f'-X {path}.BuildTime={build_time}', |
There was a problem hiding this comment.
This has the unfortunate side effect of causing an expensive re-build of the go components for every source build regardless of if anything has changed.
If there is a go version of the c date or time macros then you should use that, if not there's a way of telling scons that a subset of options shouldn't be compared against the cache when considering rebuilds, if you need me to I can look into this.
Include build timestamp in all builds. Only
include build host in non-release builds.
Change-Id: I2d5525c21da2537a9583e9dbd57265e34639913f
Required-githooks: true
Signed-off-by: Michael MacDonald mjmac@google.com