Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-14474,14219,14476,15049 dfs: dfs bug fixes #13646

Merged
merged 5 commits into from
Jan 26, 2024
Merged

DAOS-14474,14219,14476,15049 dfs: dfs bug fixes #13646

merged 5 commits into from
Jan 26, 2024

Conversation

mchaarawi
Copy link
Contributor

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@mchaarawi
DAOS-14474 dfs: remove unused --evict option from checker (#13616)
c03333f 
The dfs fs check command already allows evicting containers using the
--flags=evict option. the --evict option was added by mistake and does
not do anything today, so remove it.

Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@intel.com>
@mchaarawi
DAOS-14219 dfs: checker should not follow symlinks (#13625)
fd618df 
The DFS checker should mark the symlink oid and not dereference the
symlink value. the value can be invalid anyway and if a valid path in
the container, it would be reachable from the hardlink path.

Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@intel.com>
@mchaarawi
DAOS-14476 dfs: update root stbuf on lookup of root (#13597)
3ae8561 
- In order to avoid stale root stat data, update the root stbuf on lookup.
- add mtime/ctime proper querying for dfs_lookup()
- destroy the uns container after the link is remove since dfuse looks
  up the root if the container of being destroyed.

Required-githooks: true

Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@intel.com>
@mchaarawi
DAOS-15049 dfs: fix bug in setattr when mtime and size are being set (#…
35c13ff 
…13640)

- in dfs_osetattr(), if user sets both mtime and size, the hlc for the
  mtime is not being update on storage. To fix that, use the hlc
  reported from the array_stat and update that when updating the mtime in
  the entry.

Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@intel.com>
daosbuild1
daosbuild1 reviewed Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@github-actions GitHub Actions
Copy link

Bug-tracker data:
Errors are Ticket number suffix is not a number. See https://daosio.atlassian.net/wiki/spaces/DC/pages/11133911069/Commit+Comments,Unable to load ticket data
https://daosio.atlassian.net/browse/DAOS-14474,14219,14476,15049

@mchaarawi mchaarawi added the unclean-cherry-pick Indicates that a cherry-pick had merge conflicts that needed resolving. label Jan 23, 2024
@mchaarawi mchaarawi marked this pull request as ready for review January 23, 2024 19:54
@mchaarawi mchaarawi requested review from a team as code owners January 23, 2024 19:54
@mchaarawi mchaarawi requested review from mjmac, tanabarr, daltonbohning, wiliamhuang and jolivier23 and removed request for a team January 23, 2024 19:54
tanabarr
tanabarr approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@tanabarr tanabarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the go change looks good to me

daltonbohning
daltonbohning reviewed Jan 23, 2024
View reviewed changes
Copy link
Contributor

@daltonbohning daltonbohning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this run Features: dfs?

@mchaarawi
add features pragma for dfs
d9256f4 
Features: dfs

Required-githooks: true

Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@intel.com>
daosbuild1
daosbuild1 reviewed Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@mchaarawi
Copy link
Contributor Author

Should this run Features: dfs?

yea.. unfortunately i forgot to do that since i just cherrypicked and that was removed from the master comment. anyway, repushed

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13646/2/execution/node/1121/log

@mchaarawi mchaarawi merged commit e95ee32 into release/2.4 Jan 26, 2024
36 checks passed
@mchaarawi mchaarawi deleted the mschaara/dfs_backports branch January 26, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daosbuild1 daosbuild1 daosbuild1 left review comments

@tanabarr tanabarr tanabarr approved these changes

@jolivier23 jolivier23 jolivier23 approved these changes

@daltonbohning daltonbohning daltonbohning approved these changes

@wiliamhuang wiliamhuang wiliamhuang approved these changes

@yuvale2 yuvale2 yuvale2 approved these changes

@mjmac mjmac Awaiting requested review from mjmac mjmac is a code owner automatically assigned from daos-stack/go-watchers

Assignees
No one assigned
Labels
unclean-cherry-pick Indicates that a cherry-pick had merge conflicts that needed resolving.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mchaarawi @daosbuild1 @tanabarr @jolivier23 @daltonbohning @wiliamhuang @yuvale2