Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-14781 test: expect more containers before rdb nospace #13647

Merged
merged 1 commit into from
Jan 24, 2024
Merged

DAOS-14781 test: expect more containers before rdb nospace #13647

merged 1 commit into from
Jan 24, 2024

Conversation

kccain
Copy link
Contributor

@kccain kccain commented Jan 22, 2024 •
edited
Loading

Change the server/metdata.py tests to expect, for a pool rdb capacity of 128 MiB, out of space errors just before creating a maxiimum of about 7500 containers (increasing from the prior value 3500).

Test-tag: server,metadata
Test-repeat: 5
Skip-unit-tests: true
Skip-fault-injection-test: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@kccain
DAOS-14781 test: expect more containers before rdb nospace
449bd8a 
Change the server/metdata.py tests to expect, for a pool rdb capacity
of 128 MiB, out of space errors just before creating a maxiimum of
about 7500 containers (increasing from the prior value 3000).

Test-tag: server,metadata
Test-repeat: 5
Skip-unit-tests: true
Skip-fault-injection-test: true

Signed-off-by: Kenneth Cain <kenneth.c.cain@intel.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 22, 2024 •
edited
Loading

Bug-tracker data:
Ticket title is 'server/metadata.py:ObjectMetadata.test_metadata_fillup - metadata full error did not occur'
Status is 'In Review'
Labels: 'ci_impact,release/2.4,triaged,weekly_test'
https://daosio.atlassian.net/browse/DAOS-14781

@kccain
Copy link
Contributor Author

kccain commented Jan 23, 2024

Limited the scope of testing in this PR to just those test tags found in the ftest server/metadata.py (thus, the use of the forced-landing label in the PR). All server/metadata.py tests passed 5 times using the Test-repeat commit pragma.

@kccain kccain added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Jan 23, 2024
@kccain kccain marked this pull request as ready for review January 23, 2024 02:26
@kccain kccain requested a review from a team as a code owner January 23, 2024 02:26
@kccain kccain requested a review from liw January 23, 2024 02:26
daltonbohning
daltonbohning approved these changes Jan 23, 2024
View reviewed changes
src/tests/ftest/server/metadata.py
@@ -65,7 +65,7 @@ class ObjectMetadata(TestWithServers):
CREATED_CONTAINERS_MIN = 2900

# Number of created containers that should not be possible
CREATED_CONTAINERS_LIMIT = 3500
CREATED_CONTAINERS_LIMIT = 7500
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just pointing out this might be a moving target in the future

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. In some older discussions IIRC it was suggested to restructure the test to first probe for the number of create-able containers in a first pass, and then base any subsequent passes success criteria upon this discovered number (that there be some predictability e.g., as tested in the addremove test). Though I suppose there is some value in those constants in the current code do allow us to flag unexpected large changes such as this one. Thanks for the review & landing.

@kccain kccain requested a review from a team January 24, 2024 11:38
@daltonbohning daltonbohning merged commit 9556962 into master Jan 24, 2024
45 checks passed
@daltonbohning daltonbohning deleted the kccain/daos_14781_master branch January 24, 2024 17:00
kccain added a commit that referenced this pull request Jan 24, 2024
@kccain
DAOS-14781 test: expect more containers before rdb nospace (#13647)
fc63c76 
Change the server/metdata.py tests to expect, for a pool rdb capacity
of 128 MiB, out of space errors just before creating a maxiimum of
about 7500 containers (increasing from the prior value 3000).

Test-tag: server,metadata
Test-repeat: 5
Skip-unit-tests: true
Skip-fault-injection-test: true

Signed-off-by: Kenneth Cain <kenneth.c.cain@intel.com>
kccain added a commit that referenced this pull request Jan 26, 2024
@kccain
DAOS-14781 test: expect more containers before rdb nospace (#13647)
a8cce32 
Change the server/metdata.py tests to expect, for a pool rdb capacity
of 128 MiB, out of space errors just before creating a maxiimum of
about 7500 containers (increasing from the prior value 3000).

Test-tag: server,metadata
Test-repeat: 5
Skip-unit-tests: true
Skip-fault-injection-test: true

Signed-off-by: Kenneth Cain <kenneth.c.cain@intel.com>
@kccain kccain mentioned this pull request Jan 29, 2024
Merged
18 tasks
daltonbohning pushed a commit that referenced this pull request Jan 31, 2024
@kccain
DAOS-14781 test: expect more containers before rdb nospace (#13647) (#…
3bac1f5 
…13658)

Change the server/metdata.py tests to expect, for a pool rdb capacity
of 128 MiB, out of space errors just before creating a maxiimum of
about 7500 containers (increasing from the prior value 3000).

To avoid out of space errors on pool service replica followers,
in the server/metadata.yaml functional test config, change the
rdb log compaction frequency (RDB_COMPACT_THRESHOLD) to be once every
64 entries, rather than the prdoduct default 256. For applications
that push the metadata/rdb space to its limits, this is one tactic to
reduce the amount of free space skew between the leader and followers.
Such skew, if allowed to become too large, can cause followers to run
out of space in rdb before the next periodic trigger of log compaction.
And that of course can impact overall pool service availability.

Signed-off-by: Kenneth Cain <kenneth.c.cain@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daltonbohning daltonbohning daltonbohning approved these changes

@liw liw liw approved these changes

Assignees
No one assigned
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kccain @liw @daltonbohning