Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-15002 test: use default pool svc for rebuild tests #13648

Merged
merged 1 commit into from
Jan 29, 2024
Merged

DAOS-15002 test: use default pool svc for rebuild tests #13648

merged 1 commit into from
Jan 29, 2024

Conversation

daltonbohning
Copy link
Contributor

When possible, use the system default of svc_rf * 2 + 1 for rebuild tests instead of hardcoding to inappropriate values.

Otherwise, update some tests with svnc: 5 to account for killing a rank.

Test-tag: RbldCascadingFailures RbldDeleteObjects RbldReadArrayTest RbldContRfTest RbldWidelyStriped RbldWithIOR
Test-repeat: 2
Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@daltonbohning daltonbohning self-assigned this Jan 22, 2024
@github-actions GitHub Actions
Copy link

Bug-tracker data:
Ticket title is 'Rebuild tests unable to find any available service ranks after stopping rank'
Status is 'In Progress'
Labels: 'ci_impact,triaged,weekly_test'
https://daosio.atlassian.net/browse/DAOS-15002

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13648/2/execution/node/789/log

@daltonbohning daltonbohning force-pushed the dbohning/daos-15002 branch 3 times, most recently from a0c39e2 to 8299aac Compare January 23, 2024 16:14
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13648/5/execution/node/789/log

@daltonbohning daltonbohning force-pushed the dbohning/daos-15002 branch 2 times, most recently from b376689 to 7791a24 Compare January 24, 2024 16:12
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13648/7/execution/node/812/log

@daltonbohning
DAOS-15002 test: use default pool svc for rebuild tests
f29cc34 
When possible, use the system default of svc_rf * 2 + 1 for rebuild tests
instead of hardcoding to inappropriate values.

Otherwise, update some tests with svnc: 5 to account for killing a rank.

Test-tag: RbldCascadingFailures RbldDeleteObjects RbldReadArrayTest RbldContRfTest RbldWidelyStriped RbldWithIOR EcodOfflineRebuildSingle EcodOnlineMultFail EcodOfflineRebuild EcodOfflineRebuildSingle EcodOnlineRebuild EcodDisabledRebuildSingle EcodDisabledRebuild ServerRankFailure ContRfEnforce
Test-repeat: 1
Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13648/8/testReport/

@daltonbohning
Copy link
Contributor Author

daltonbohning commented Jan 26, 2024 •
edited
Loading

Got a clean run with Test-repeat: 1
https://build.hpdd.intel.com/blue/organizations/jenkins/daos-stack%2Fdaos/detail/PR-13648/9/tests

@daltonbohning daltonbohning marked this pull request as ready for review January 26, 2024 18:40
@daltonbohning daltonbohning requested a review from a team as a code owner January 26, 2024 18:40
wangdi1
wangdi1 approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@wangdi1 wangdi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Dalton

liw
liw approved these changes Jan 28, 2024
View reviewed changes
Copy link
Contributor

@liw liw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Dalton.

src/tests/ftest/rebuild/container_rf.yaml
svcn: 3
control_method: dmg
size: 1G
svcn: 7 # To match number of servers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic should be: "This test kills 3 engines." => "It needs at least 3 * 2 + 1 = 7 PS replicas to avoid losing the PS." => "It needs at least 7 engines for 7 PS replicas."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. This test has some other issues I need to fix as part of https://daosio.atlassian.net/browse/DAOS-15074.
I want to make this more flexible then

Copy link
Contributor

@liw liw Jan 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daltonbohning, sorry for the ambiguity. I mean the comment "to match number of servers" is not accurate; it should be something along the line of "to allow killing 3 engines". That is, the number of PS replicas depends on the number of engines the test kills, and the number of engines depends on the number of PS replicas; not the other way around.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, I understand! I also set the svcn to exactly the number of servers so all ranks will be svc ranks, making this test a little more deterministic until I fix it properly. E.g. there are some cases where I think the test needs to look at which ranks are svc ranks before killing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! I think "7 engines and 7 PS replicas" is good enough, for there's no external interface for knowing the current, exact set of PS replicas.

@phender phender merged commit 8909179 into master Jan 29, 2024
42 checks passed
@phender phender deleted the dbohning/daos-15002 branch January 29, 2024 14:29
daltonbohning added a commit that referenced this pull request Feb 2, 2024
@daltonbohning
DAOS-15002 test: use default pool svc for rebuild tests (#13648)
b5c76bf 
Test-tag: RbldCascadingFailures RbldDeleteObjects RbldReadArrayTest RbldContRfTest RbldWidelyStriped RbldWithIOR EcodOfflineRebuildSingle EcodOnlineMultFail EcodOfflineRebuild EcodOfflineRebuildSingle EcodOnlineRebuild EcodDisabledRebuildSingle EcodDisabledRebuild ServerRankFailure ContRfEnforce
Test-repeat: 1
Skip-unit-tests: true
Skip-fault-injection-test: true

When possible, use the system default of svc_rf * 2 + 1 for rebuild tests
instead of hardcoding to inappropriate values.

Otherwise, update some tests with svnc: 5 to account for killing a rank.

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
daltonbohning added a commit that referenced this pull request Feb 2, 2024
@daltonbohning
DAOS-15002 test: use default pool svc for rebuild tests (#13648)
e14153c 
Test-tag: RbldCascadingFailures RbldDeleteObjects RbldReadArrayTest RbldContRfTest RbldWidelyStriped RbldWithIOR EcodOfflineRebuildSingle EcodOnlineMultFail EcodOfflineRebuild EcodOfflineRebuildSingle EcodOnlineRebuild EcodDisabledRebuildSingle EcodDisabledRebuild ServerRankFailure ContRfEnforce
Test-repeat: 1
Skip-unit-tests: true
Skip-fault-injection-test: true

When possible, use the system default of svc_rf * 2 + 1 for rebuild tests
instead of hardcoding to inappropriate values.

Otherwise, update some tests with svnc: 5 to account for killing a rank.

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liw liw liw approved these changes

@wangdi1 wangdi1 wangdi1 approved these changes

@phender phender Awaiting requested review from phender

Assignees

@daltonbohning daltonbohning

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@daltonbohning @daosbuild1 @liw @wangdi1 @phender