DAOS-15136 client: Switch to using libfused #14077

jolivier23 · 2024-03-28T00:53:09Z

Switch to using libfused instead of libfuse3

PR-repos: fused@PR-1:25

Required-githooks: true

Change-Id: I382b96a17a8d503d6cf7321b57050e7ab0c187d4

Before requesting gatekeeper:

Two review approvals and any prior change requests have been resolved.
Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
Commit messages follows the guidelines outlined here.
Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

github-actions · 2024-03-28T00:53:30Z

Ticket title is 'we build a libfuse rpm but there is no matching developer build'
Status is 'In Progress'
Labels: 'triaged'
https://daosio.atlassian.net/browse/DAOS-15136

daosbuild1 · 2024-03-28T00:57:42Z

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/2/execution/node/354/log

daosbuild1 · 2024-03-28T00:58:52Z

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/2/execution/node/327/log

daosbuild1 · 2024-03-28T00:59:53Z

Test stage Build RPM on Leap 15.5 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/2/execution/node/287/log

daosbuild1 · 2024-03-28T01:04:27Z

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/2/execution/node/351/log

daosbuild1 · 2024-03-28T01:33:16Z

Test stage Build RPM on Leap 15.5 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/4/execution/node/349/log

daosbuild1 · 2024-03-28T01:34:55Z

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/4/execution/node/341/log

daosbuild1 · 2024-03-28T01:37:04Z

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/4/execution/node/369/log

daosbuild1 · 2024-03-28T01:37:22Z

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/4/execution/node/353/log

daosbuild1 · 2024-03-28T02:18:58Z

Test stage Build RPM on Leap 15.5 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/5/execution/node/270/log

daosbuild1 · 2024-03-28T02:21:09Z

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/5/execution/node/349/log

daosbuild1 · 2024-03-28T02:23:08Z

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/5/execution/node/309/log

daosbuild1 · 2024-03-28T02:27:25Z

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/5/execution/node/355/log

daosbuild1 · 2024-03-28T03:01:26Z

Test stage Build RPM on Leap 15.5 completed with status UNSTABLE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/6/execution/node/287/log

daosbuild1 · 2024-03-28T03:02:07Z

Test stage Build RPM on EL 8 completed with status UNSTABLE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/6/execution/node/364/log

daosbuild1 · 2024-03-28T03:06:06Z

Test stage Build DEB on Ubuntu 20.04 completed with status UNSTABLE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/6/execution/node/350/log

Switch to using libfused instead of libfuse3 PR-repos: fused@PR-1:28 Required-githooks: true Change-Id: I382b96a17a8d503d6cf7321b57050e7ab0c187d4 Signed-off-by: Jeff Olivier <jeffolivier@google.com>

Required-githooks: true Change-Id: Iddf5882e12161746511e598b3cb4ae380af35683

Required-githooks: true Change-Id: Icdd7235f8a93363ee7cc33a1adb5e3c43956c4aa Signed-off-by: Jeff Olivier <jeffolivier@google.com>

daosbuild1 · 2024-03-28T16:19:03Z

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/8/execution/node/326/log

daosbuild1 · 2024-03-28T16:19:27Z

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/8/execution/node/345/log

daosbuild1 · 2024-03-28T16:21:00Z

Test stage Build RPM on Leap 15.5 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/8/execution/node/329/log

daosbuild1 · 2024-03-28T16:21:57Z

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/8/execution/node/338/log

ashleypittman · 2024-04-25T18:09:15Z

debian/changelog

 daos (2.5.101-3) unstable; urgency=medium
  [ Ashley M. Pittman ]
  * Updated pydaos install process

 -- Ashley M. Pittman <ashley.m.pittman@intel.com>  Thu, 04 Apr 2024 09:15:00 -0800
+>>>>>>> master


Bad merge here.

Required-githooks: true Signed-off-by: Jeff Olivier <jeffolivier@google.com>

Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com>

Try setting memcheck default to no Required-githooks: true Signed-off-by: Jeff Olivier <jeffolivier@google.com>

ashleypittman · 2024-04-26T18:04:26Z

src/client/dfuse/SConscript

@@ -140,7 +140,7 @@ def check_ioctl_def(context, ctype):
    context.Message(f'Checking if fuse ioctl is type {ctype} ')

    # pylint: disable-next=consider-using-f-string
-    src = """#include <fuse3/fuse_lowlevel.h>
+    src = """#include <fused/fuse_lowlevel.h>


This is for working with various fuse versions, we should replace this with a simple version check.

brianjmurrell · 2024-06-05T18:57:17Z

site_scons/components/__init__.py

+                commands=[['find', '../fused', '-type', 'f', '-name', '*', '-exec', 'sed', '-i',
+                           's/fuse3/fused/g', '{}', ';'],


See comments in daos-stack/fused#1 about -name * and xargs.

brianjmurrell · 2024-06-05T18:59:00Z

utils/build.config

@@ -3,7 +3,7 @@ component=daos

 [commit_versions]
 ARGOBOTS = v1.1
-FUSE = fuse-3.16.2
+FUSED = master


Would it be better to pin this for build reproducibiliy?

brianjmurrell · 2024-06-05T19:02:16Z

utils/rpms/daos.spec

 %if (0%{?rhel} >= 8)
-BuildRequires: fuse3-devel >= 3
+BuildRequires: fused-devel >= 1
 %else
-BuildRequires: fuse3-devel >= 3.4.2
+BuildRequires: fused-devel >= 1
 %endif


The >= 1 is redundant here as is the %if branch.

Suggested change

%if (0%{?rhel} >= 8)

BuildRequires: fuse3-devel >= 3

BuildRequires: fused-devel >= 1

%else

BuildRequires: fuse3-devel >= 3.4.2

BuildRequires: fused-devel >= 1

%endif

BuildRequires: fused-devel

(Sorry, GH is really mangling this suggestion due to the unchanged lines in it.)

brianjmurrell · 2024-06-05T19:02:47Z

utils/rpms/daos.spec

@@ -175,7 +175,7 @@ Requires: mercury >= %{mercury_version}
 Requires: libfabric >= %{libfabric_version}
 %if (0%{?suse_version} >= 1500)
 Requires: libfabric1 >= %{libfabric_version}
-Requires: libfuse3-3 >= 3.4.2
+Requires: fused >= 1


Not at all necessary.

Suggested change

Requires: fused >= 1

brianjmurrell · 2024-06-05T19:03:08Z

utils/rpms/daos.spec

-%else
-Requires: fuse3-devel >= 3.4.2
-%endif
+Requires: fused >= 1


Ditto, if this really should be a change from fused-devel to fused but it's not clear why the -devel is not needed here now.

So either:

Suggested change

Requires: fused >= 1

or

Suggested change

Requires: fused >= 1

Requires: fused-devel

brianjmurrell · 2024-06-05T19:05:30Z

utils/rpms/daos.spec

@@ -587,6 +583,9 @@ getent passwd daos_agent >/dev/null || useradd -s /sbin/nologin -r -g daos_agent
 # No files in a shim package

 %changelog
+* Thu Apr 25 2024 Jeff Olivier <jeffolivier@google.com> 2.5.101-5


This datestamp could use an update.

brianjmurrell · 2024-06-05T19:05:56Z

debian/changelog

+  [ Jeff Olivier ]
+  * Switch from libfuse3 to libfused
+
+ -- Jeff Olivier <jeffolivier@google.com>  Thu, 25 Apr 2024 10:30:00 +0000


Worth bringing this timestamp up-to-date.

Required-githooks: true Signed-off-by: Jeff Olivier <jeffolivier@google.com>

Features: dfuse Required-githooks: true Signed-off-by: Jeff Olivier <jeffolivier@google.com>

Required-githooks: true Features: dfuse Signed-off-by: Jeff Olivier <jeffolivier@google.com>

Brian has retired

jolivier23 · 2024-12-20T04:11:14Z

I started looking at static compilation and it wasn't trivial (no debian packages in daos-stack/fused, for example) so I thought I would try to finish this.

fused is currently in sync with libfuse head so need some validation but it has all of the patches. I changed tactics to just do a few renames from fuse3 to fused which hopefully won't cause too many future conflicts when syncing.

Required-githooks: true Signed-off-by: Jeff Olivier <jeffolivier@google.com>

Features: dfuse Allow-unstable-test: true Required-githooks: true Signed-off-by: Jeff Olivier <jeffolivier@google.com>

Allow-unstable-test: true Features: dfuse Required-githooks: true Signed-off-by: Jeff Olivier <jeffolivier@google.com>

daosbuild1 · 2024-12-20T16:02:50Z

Test stage NLT on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/20/execution/node/817/log

Allow-unstable-test: true Features: dfuse Required-githooks: true Signed-off-by: Jeff Olivier <jeffolivier@google.com>

daosbuild1 · 2024-12-21T00:56:27Z

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14077/21/testReport/

Allow-unstable-test: true Features: dfuse Required-githooks: true Signed-off-by: Jeff Olivier <jeffolivier@google.com>

Features: dfuse Allow-unstable-test: true

daosbuild1 · 2024-12-21T06:03:24Z

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14077/23/testReport/

daosbuild1 · 2024-12-22T10:25:45Z

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14077/23/execution/node/1425/log

Allow-unstable-test: true Features: dfuse

jolivier23 force-pushed the jvolivie/fused branch from ad0ec30 to 77dc952 Compare March 28, 2024 00:54

jolivier23 force-pushed the jvolivie/fused branch 2 times, most recently from 825db6d to 3105249 Compare March 28, 2024 01:27

jolivier23 force-pushed the jvolivie/fused branch from 3105249 to 498f312 Compare March 28, 2024 02:13

jolivier23 force-pushed the jvolivie/fused branch from 498f312 to 5bfee34 Compare March 28, 2024 02:53

jolivier23 force-pushed the jvolivie/fused branch from 5bfee34 to 2c75fc4 Compare March 28, 2024 03:05

jolivier23 added 3 commits March 28, 2024 08:40

DAOS-15136 client: Switch to using libfused

df7aadc

Switch to using libfused instead of libfuse3 PR-repos: fused@PR-1:28 Required-githooks: true Change-Id: I382b96a17a8d503d6cf7321b57050e7ab0c187d4 Signed-off-by: Jeff Olivier <jeffolivier@google.com>

Merge branch 'master' into jvolivie/fused

7bf9fb8

Required-githooks: true Change-Id: Iddf5882e12161746511e598b3cb4ae380af35683

PR-repos: fused@1:28

20bf3b6

Required-githooks: true Change-Id: Icdd7235f8a93363ee7cc33a1adb5e3c43956c4aa Signed-off-by: Jeff Olivier <jeffolivier@google.com>

jolivier23 force-pushed the jvolivie/fused branch from 2c75fc4 to 20bf3b6 Compare March 28, 2024 16:16

ashleypittman reviewed Apr 25, 2024

View reviewed changes

jolivier23 and others added 5 commits April 25, 2024 13:25

fix bad merge

1a37b21

Required-githooks: true Signed-off-by: Jeff Olivier <jeffolivier@google.com>

Merge branch 'master' into jvolivie/fused

ef30117

Required-githooks: true Signed-off-by: Jeff Olivier <jeffolivier@google.com>

PR-repos: fused@PR-1:29

22ac591

Required-githooks: true Signed-off-by: Jeff Olivier <jeffolivier@google.com>

DAOS-15753 dfuse: Do not deadlock when failing to mount.

926f43a

Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com>

PR-repos: fused@PR-1:29

2a8ff90

Try setting memcheck default to no Required-githooks: true Signed-off-by: Jeff Olivier <jeffolivier@google.com>

ashleypittman reviewed Apr 26, 2024

View reviewed changes

jolivier23 mentioned this pull request Jun 5, 2024

DAOS-623 build: Create a simple RPM package daos-stack/fused#1

Merged

brianjmurrell previously requested changes Jun 5, 2024

View reviewed changes

jolivier23 added 4 commits December 19, 2024 20:24

Merge branch 'master' into jvolivie/fused

e5fbffa

Required-githooks: true Signed-off-by: Jeff Olivier <jeffolivier@google.com>

Empty commit for pragmas

e991acb

Features: dfuse Required-githooks: true Signed-off-by: Jeff Olivier <jeffolivier@google.com>

Remove the sed

18b1e5e

Features: dfuse Required-githooks: true Signed-off-by: Jeff Olivier <jeffolivier@google.com>

Fix a few more issues

a397c1e

Required-githooks: true Features: dfuse Signed-off-by: Jeff Olivier <jeffolivier@google.com>

jolivier23 requested review from johannlombardi and mchaarawi December 20, 2024 04:09

jolivier23 added 5 commits December 19, 2024 21:22

Features: dfuse

dc5d340

Required-githooks: true Signed-off-by: Jeff Olivier <jeffolivier@google.com>

Clean up rpm dependencies

85041ed

Required-githooks: true Signed-off-by: Jeff Olivier <jeffolivier@google.com>

empty commit for test

0ed4c7c

Features: dfuse Allow-unstable-test: true Required-githooks: true Signed-off-by: Jeff Olivier <jeffolivier@google.com>

Add back valgrind testing

4b266cf

Features: dfuse Allow-unstable-test: true Required-githooks: true Signed-off-by: Jeff Olivier <jeffolivier@google.com>

fix typo

3f3a397

Allow-unstable-test: true Features: dfuse Required-githooks: true Signed-off-by: Jeff Olivier <jeffolivier@google.com>

Try again

515b136

Allow-unstable-test: true Features: dfuse Required-githooks: true Signed-off-by: Jeff Olivier <jeffolivier@google.com>

jolivier23 added 2 commits December 20, 2024 22:03

Add missing FUSE_CAP for printing

7585023

Allow-unstable-test: true Features: dfuse Required-githooks: true Signed-off-by: Jeff Olivier <jeffolivier@google.com>

Merge branch 'master' into jvolivie/fused

45a2e77

Features: dfuse Allow-unstable-test: true

Merge branch 'master' into jvolivie/fused

c1082d5

Allow-unstable-test: true Features: dfuse

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DAOS-15136 client: Switch to using libfused #14077

DAOS-15136 client: Switch to using libfused #14077

jolivier23 commented Mar 28, 2024

github-actions bot commented Mar 28, 2024 •

edited

Loading

daosbuild1 commented Mar 28, 2024

daosbuild1 commented Mar 28, 2024

daosbuild1 commented Mar 28, 2024

daosbuild1 commented Mar 28, 2024

daosbuild1 commented Mar 28, 2024

daosbuild1 commented Mar 28, 2024

daosbuild1 commented Mar 28, 2024

daosbuild1 commented Mar 28, 2024

daosbuild1 commented Mar 28, 2024

daosbuild1 commented Mar 28, 2024

daosbuild1 commented Mar 28, 2024

daosbuild1 commented Mar 28, 2024

daosbuild1 commented Mar 28, 2024

daosbuild1 commented Mar 28, 2024

daosbuild1 commented Mar 28, 2024

daosbuild1 commented Mar 28, 2024

daosbuild1 commented Mar 28, 2024

daosbuild1 commented Mar 28, 2024

daosbuild1 commented Mar 28, 2024

ashleypittman Apr 25, 2024

ashleypittman Apr 26, 2024

brianjmurrell Jun 5, 2024

brianjmurrell Jun 5, 2024

brianjmurrell Jun 5, 2024

brianjmurrell Jun 5, 2024

brianjmurrell Jun 5, 2024

brianjmurrell Jun 5, 2024

brianjmurrell Jun 5, 2024

jolivier23 commented Dec 20, 2024

daosbuild1 commented Dec 20, 2024

daosbuild1 commented Dec 21, 2024

daosbuild1 commented Dec 21, 2024

daosbuild1 commented Dec 22, 2024

		commands=[['find', '../fused', '-type', 'f', '-name', '*', '-exec', 'sed', '-i',
		's/fuse3/fused/g', '{}', ';'],

DAOS-15136 client: Switch to using libfused #14077

Are you sure you want to change the base?

DAOS-15136 client: Switch to using libfused #14077

Conversation

jolivier23 commented Mar 28, 2024

Before requesting gatekeeper:

Gatekeeper:

github-actions bot commented Mar 28, 2024 • edited Loading

daosbuild1 commented Mar 28, 2024

daosbuild1 commented Mar 28, 2024

daosbuild1 commented Mar 28, 2024

daosbuild1 commented Mar 28, 2024

daosbuild1 commented Mar 28, 2024

daosbuild1 commented Mar 28, 2024

daosbuild1 commented Mar 28, 2024

daosbuild1 commented Mar 28, 2024

daosbuild1 commented Mar 28, 2024

daosbuild1 commented Mar 28, 2024

daosbuild1 commented Mar 28, 2024

daosbuild1 commented Mar 28, 2024

daosbuild1 commented Mar 28, 2024

daosbuild1 commented Mar 28, 2024

daosbuild1 commented Mar 28, 2024

daosbuild1 commented Mar 28, 2024

daosbuild1 commented Mar 28, 2024

daosbuild1 commented Mar 28, 2024

daosbuild1 commented Mar 28, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jolivier23 commented Dec 20, 2024

daosbuild1 commented Dec 20, 2024

daosbuild1 commented Dec 21, 2024

daosbuild1 commented Dec 21, 2024

daosbuild1 commented Dec 22, 2024

github-actions bot commented Mar 28, 2024 •

edited

Loading