Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-XXX engine: Add single engine multi-socket mode #14160

Closed
wants to merge 1 commit into from
Closed

DAOS-XXX engine: Add single engine multi-socket mode #14160

wants to merge 1 commit into from
+176 −62

Conversation

jolivier23
Copy link
Contributor

For simplicity, target and helper count must be a multiple of the number of sockets and there must be fewer helpers than targets.

Let's say K is the number of xstreams of each type that map to a numa node. They are assigned in order with K going to the first node, K to the second, etc.

Enabled with DAOS_MULTISOCKET=1

If not enabled, it should work as it did before.

Required-githooks: true

Change-Id: Ia7801289f4cc9e2cca4649d5132a1a5c0ea2f299

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@github-actions GitHub Actions
Copy link

Bug-tracker data:
Errors are Ticket number suffix is not a number. See https://daosio.atlassian.net/wiki/spaces/DC/pages/11133911069/Commit+Comments,Unable to load ticket data
https://daosio.atlassian.net/browse/DAOS-XXX

@daosbuild1
Copy link
Collaborator

Test stage Python Bandit check completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14160/1/execution/node/164/log

daosbuild1
daosbuild1 previously requested changes Apr 13, 2024
View reviewed changes
src/engine/init.c
}
for (i = 0; i < numa_node_nr; i++) {
hwloc_obj_t numa_obj;
numa_info[i].ni_idx = i;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
numa_info[i].ni_idx = i;
hwloc_obj_t numa_obj;

src/engine/srv_internal.h
/** Allocation bitmap for numa node */
hwloc_bitmap_t ni_core_allocation_bitmap;
};
/** Cached numa information */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/** Cached numa information */
};

@daosbuild1
Copy link
Collaborator

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14160/1/execution/node/212/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14160/1/execution/node/361/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.5 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14160/1/execution/node/405/log

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14160/1/execution/node/383/log

@daosbuild1 daosbuild1 dismissed their stale review April 17, 2024 14:57

Updated patch

daosbuild1
daosbuild1 previously requested changes Apr 17, 2024
View reviewed changes
src/engine/init.c
}
for (i = 0; i < numa_node_nr; i++) {
hwloc_obj_t numa_obj;
numa_info[i].ni_idx = i;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
numa_info[i].ni_idx = i;
hwloc_obj_t numa_obj;

src/engine/srv_internal.h
/** Allocation bitmap for numa node */
hwloc_bitmap_t ni_core_allocation_bitmap;
};
/** Cached numa information */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/** Cached numa information */
};

@daosbuild1
Copy link
Collaborator

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14160/2/execution/node/147/log

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14160/2/testReport/

Base automatically changed from jvolivie/backport_io_forward to google/2.4 April 19, 2024 17:59
@daosbuild1 daosbuild1 dismissed their stale review April 19, 2024 18:01

Updated patch

daosbuild1
daosbuild1 previously requested changes Apr 19, 2024
View reviewed changes
src/engine/init.c
}
for (i = 0; i < numa_node_nr; i++) {
hwloc_obj_t numa_obj;
numa_info[i].ni_idx = i;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
numa_info[i].ni_idx = i;
hwloc_obj_t numa_obj;

src/engine/srv_internal.h
/** Allocation bitmap for numa node */
hwloc_bitmap_t ni_core_allocation_bitmap;
};
/** Cached numa information */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/** Cached numa information */
};

@daosbuild1
Copy link
Collaborator

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14160/3/execution/node/204/log

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14160/3/testReport/

@jolivier23
DAOS-XXX engine: Add single engine multi-socket mode
15a116e 
For simplicity, target and helper count must be a multiple
of the number of sockets and there must be fewer helpers
than targets.

Let's say K is the number of xstreams of each type that map to
a numa node. They are assigned in order with K going to the
first node, K to the second, etc.

Enabled with DAOS_MULTISOCKET=1

If not enabled, it should work as it did before.

Required-githooks: true

Change-Id: Ia7801289f4cc9e2cca4649d5132a1a5c0ea2f299
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@daosbuild1 daosbuild1 dismissed their stale review April 22, 2024 23:28

Updated patch

daosbuild1
daosbuild1 requested changes Apr 22, 2024
View reviewed changes
src/engine/init.c
}
for (i = 0; i < numa_node_nr; i++) {
hwloc_obj_t numa_obj;
numa_info[i].ni_idx = i;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
numa_info[i].ni_idx = i;
hwloc_obj_t numa_obj;

src/engine/srv_internal.h
/** Allocation bitmap for numa node */
hwloc_bitmap_t ni_core_allocation_bitmap;
};
/** Cached numa information */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/** Cached numa information */
};

@daosbuild1
Copy link
Collaborator

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14160/4/execution/node/176/log

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14160/4/testReport/

@jolivier23 jolivier23 closed this Apr 25, 2024
@jolivier23 jolivier23 deleted the jvolivie/add_mode branch April 25, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daosbuild1 daosbuild1 daosbuild1 requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jolivier23 @daosbuild1