Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-15276 object: refine sgl valid check #14176

Merged
merged 2 commits into from
May 13, 2024
Merged

DAOS-15276 object: refine sgl valid check #14176

merged 2 commits into from
May 13, 2024

Conversation

liuxuezhao
Copy link
Contributor

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@liuxuezhao liuxuezhao requested review from a team as code owners April 17, 2024 09:38
@github-actions GitHub Actions
Copy link

Errors are Unable to load ticket data
https://daosio.atlassian.net/browse/DAOS-15276

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14176/2/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14176/2/execution/node/1435/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14176/2/execution/node/1451/log

@liuxuezhao liuxuezhao force-pushed the lxz/sgl_check branch 2 times, most recently from 33727e2 to a5dcaf8 Compare April 23, 2024 02:10
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14176/4/execution/node/1451/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14176/4/execution/node/1592/log

@liuxuezhao liuxuezhao requested review from a team as code owners April 24, 2024 08:41
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14176/5/testReport/

NiuYawei
NiuYawei previously approved these changes Apr 30, 2024
View reviewed changes
src/object/cli_obj.c Outdated Show resolved Hide resolved
wangshilong
wangshilong previously approved these changes Apr 30, 2024
View reviewed changes
@liuxuezhao liuxuezhao requested a review from a team April 30, 2024 01:11
@liuxuezhao
Copy link
Contributor Author

@daos-stack/daos-gatekeeper ping, thx

mchaarawi
mchaarawi reviewed May 6, 2024
View reviewed changes
Copy link
Contributor

@mchaarawi mchaarawi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a proper commit message (PR description) for landing.
please fix the error message "Bad iov". you can do it in same PR or following PR, but it needs to be fix as it's user facing/

mchaarawi
mchaarawi requested changes May 6, 2024
View reviewed changes
src/client/dfs/xattr.c Outdated Show resolved Hide resolved
src/client/dfs/xattr.c Outdated Show resolved Hide resolved
@liuxuezhao liuxuezhao requested a review from mchaarawi May 7, 2024 07:34
@liuxuezhao liuxuezhao dismissed stale reviews from wangshilong and NiuYawei via e7456db May 7, 2024 15:17
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14176/7/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14176/8/execution/node/1454/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14176/8/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14176/9/testReport/

@liuxuezhao
DAOS-15276 object: refine sgl valid check
25cca27 
Refine sgl check to avoid segfault for special sgl parameter.
Add a test case for it.

Required-githooks: true

Signed-off-by: Xuezhao Liu <xuezhao.liu@intel.com>
@liuxuezhao
DAOS-15276 object: log refine
fa264fb 
Required-githooks: true

Signed-off-by: Xuezhao Liu <xuezhao.liu@intel.com>
@liuxuezhao
Copy link
Contributor Author

liuxuezhao commented May 10, 2024 •
edited
Loading

@mchaarawi I reverted the parameter check in dfs, changed to "if (value == NULL) d_iov_set(&sg_iovs[0], NULL, 0);" that probably is safer. Is it find to you?

@mchaarawi
Copy link
Contributor

@mchaarawi I reverted the parameter check in dfs, changed to "if (value == NULL) d_iov_set(&sg_iovs[0], NULL, 0);" that probably is safer. Is it find to you?

yes thanks for changing that

@liuxuezhao
Copy link
Contributor Author

@mchaarawi I reverted the parameter check in dfs, changed to "if (value == NULL) d_iov_set(&sg_iovs[0], NULL, 0);" that probably is safer. Is it find to you?

yes thanks for changing that

OK, there still with a "-1" left by you, any other concern?

@mchaarawi
Copy link
Contributor

@mchaarawi I reverted the parameter check in dfs, changed to "if (value == NULL) d_iov_set(&sg_iovs[0], NULL, 0);" that probably is safer. Is it find to you?

yes thanks for changing that

OK, there still with a "-1" left by you, any other concern?

oh sorry, i thought i removed that.

Nasf-Fan
Nasf-Fan approved these changes May 13, 2024
View reviewed changes
src/object/cli_obj.c
@@ -2216,6 +2216,22 @@ obj_iod_sgl_valid(daos_obj_id_t oid, unsigned int nr, daos_iod_t *iods,
return -DER_INVAL;
}
}
if (sgls != NULL && sgls[i].sg_nr > 0) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"if (sgls != NULL) {" seems enough.

@liuxuezhao liuxuezhao requested a review from a team May 13, 2024 01:27
@mchaarawi mchaarawi merged commit 4f2148a into master May 13, 2024
50 of 51 checks passed
@mchaarawi mchaarawi deleted the lxz/sgl_check branch May 13, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nasf-Fan Nasf-Fan Nasf-Fan approved these changes

@mchaarawi mchaarawi mchaarawi approved these changes

@NiuYawei NiuYawei NiuYawei left review comments

@wangshilong wangshilong wangshilong left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@liuxuezhao @daosbuild1 @mchaarawi @wangshilong @NiuYawei @Nasf-Fan