Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple merge #14192

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Simple merge #14192

merged 2 commits into from
Apr 18, 2024

Conversation

jolivier23
Copy link
Contributor

Required-githooks: true

Change-Id: I81c32246ee0956fe2c380ccfb78875d8acdb1256
Signed-off-by: Jeff Olivier jeffolivier@google.com

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@jolivier23
Add a dumb change
73d2d02 
Required-githooks: true

Change-Id: I81c32246ee0956fe2c380ccfb78875d8acdb1256
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23
Merge branch 'jvolivie/goog1' into jvolivie/goog2
0099a9b 
Change-Id: I3c2b0edef4ac9bf522bf584055c8ce69f5378610
@github-actions GitHub Actions
Copy link

Bug-tracker data:
Errors are component not formatted correctly,Ticket number prefix incorrect,PR title is malformatted. See https://daosio.atlassian.net/wiki/spaces/DC/pages/11133911069/Commit+Comments,Unable to load ticket data
https://daosio.atlassian.net/browse/Simple

@jolivier23 jolivier23 merged commit 907ba93 into jvolivie/goog1 Apr 18, 2024
16 of 18 checks passed
@jolivier23 jolivier23 deleted the jvolivie/goog2 branch April 18, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jolivier23