Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-14850 control: Allow logging.Logger in Context (#13569) #14210

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

mjmac
Copy link
Contributor

@mjmac mjmac commented Apr 22, 2024

Updates control plane tools to set a context in a logger
for ease of debug/trace logging.

Signed-off-by: Michael MacDonald mjmac@google.com

Copy link

Bug-tracker data:
Ticket title is 'Allow logging.Logger to be conveyed via context.Context'
Status is 'Resolved'
https://daosio.atlassian.net/browse/DAOS-14850

Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14210/1/testReport/

Updates control plane tools to set a context in a logger
for ease of debug/trace logging.

Required-githooks: true

Change-Id: I1adf4bf02cb1955128b5a279a520215530db96a1
Signed-off-by: Michael MacDonald <mjmac@google.com>
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@mjmac mjmac merged commit 2d68c65 into google/2.4 Apr 24, 2024
33 of 34 checks passed
@mjmac mjmac deleted the mjmac/DAOS-14850-2.4 branch April 24, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants