DAOS-15431 vos: clear DTX in CoS cache for the one committed by other - b24 #14324
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible that the DTX is committed locally via commit-on-share mechanism during some subsequent modification. But such modification may get failure on some remote paraticipant. Then the DTX entry will not be removed from CoS cache under such case because we do not know whether such DTX has already been committed on remote participant(s) successfully or not. Keeping it in CoS cache will allow us to re-try the commit globally sometime later.
Next time, when we re-try to commit such DTX globally, if all remote participants claim as done (return 0 or DER_NONEXIST or DER_ALREADY) successfully, then even if local VOS calims as DER_ALREADY, we still need to remove the DTX entry from CoS cache. Otherwise, we will find such DTX entry in the CoS cache everytime for batched commit (or DTX resync) as to block related process.
Before requesting gatekeeper:
Features:
(orTest-tag*
) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.Gatekeeper: