Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-14739 pool: Add service-level metrics (#14273) #14378

Merged
merged 1 commit into from
May 16, 2024

Conversation

mjmac
Copy link
Contributor

@mjmac mjmac commented May 15, 2024

Adds a new /svc group under each pool which contains
the following set of metrics:

  • leader (gauge): Current pool service leader rank
  • map_version (counter): Current pool map version
  • open_pool_handles (gauge): Current count of open handles
  • total_ranks (gauge): Number of ranks in pool map
  • degraded_ranks (gauge): Number of ranks with disabled targets
  • total_targets (gauge): Number of targets in pool map
  • disabled_targets (gauge): Number of targets marked disabled
  • draining_targets (gauge): Number of targets in draining state

For non-leader ranks, the service metrics will have zero
values. Telemetry consumers may positively identify the
current leader by checking the value of map_version, which
will always be non-zero for the leader.

Required-githooks: true

Change-Id: I6e82db981247f3e4fe4e2b434a688d4083be158c
Signed-off-by: Michael MacDonald mjmac@google.com

Adds a new /svc group under each pool which contains
the following set of metrics:
  * leader (gauge): Current pool service leader rank
  * map_version (counter): Current pool map version
  * open_pool_handles (gauge): Current count of open handles
  * total_ranks (gauge): Number of ranks in pool map
  * degraded_ranks (gauge): Number of ranks with disabled targets
  * total_targets (gauge): Number of targets in pool map
  * disabled_targets (gauge): Number of targets marked disabled
  * draining_targets (gauge): Number of targets in draining state

For non-leader ranks, the service metrics will have zero
values. Telemetry consumers may positively identify the
current leader by checking the value of map_version, which
will always be non-zero for the leader.

Required-githooks: true

Change-Id: I6e82db981247f3e4fe4e2b434a688d4083be158c
Signed-off-by: Michael MacDonald <mjmac@google.com>
Copy link

Bug-tracker data:
Ticket title is 'Expanded pool/container metrics'
Status is 'Open'
https://daosio.atlassian.net/browse/DAOS-14739

Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@mjmac mjmac requested a review from jolivier23 May 15, 2024 19:31
@mjmac mjmac merged commit 5bb8e48 into google/2.4 May 16, 2024
35 checks passed
@mjmac mjmac deleted the dev/mjmac/DAOS-14739-backport branch May 16, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants