Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-15794 tools: Add --health-only flag to (dmg|daos) pool query #14414

Merged
merged 4 commits into from
May 22, 2024

Conversation

mjmac
Copy link
Contributor

@mjmac mjmac commented May 22, 2024

As a convenience, provide a "streamlined" version of the pool
query that only performs the minimum amount of work to query
the pool's health. Practically speaking, this means that it
will query for disabled ranks and omit the space query, which
is expensive.

Includes the following PR backports:

ravalsam and others added 2 commits May 22, 2024 00:07
- Adding CLI option to filter rebuild status!= idle from dmg pool list command.
- Show pool state as Degraded when any targets are missing or device are evicted.

Required-githooks: true

Change-Id: I01ed7cd3eb8e7e6b7385b3e724d3b82736965f21
Signed-off-by: Samir Raval <samir.raval@intel.com>
…uild_state (#12983)

Description: added pool state and rebuild_state to pool list verbose verification.

Required-githooks: true

Change-Id: I46e5082886ed11c6fe96b190ce9eaff795b19799
Signed-off-by: Ding Ho ding-hwa.ho@intel.com
Copy link

github-actions bot commented May 22, 2024

Bug-tracker data:
Ticket title is 'Add --health-only flag to (dmg|daos) pool query commands'
Status is 'In Review'
https://daosio.atlassian.net/browse/DAOS-15794

@mjmac mjmac changed the title dev/mjmac/DAOS 15794 DAOS-15794 tools: Add --health-only flag to (dmg|daos) pool query May 22, 2024
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

mjmac added 2 commits May 22, 2024 01:03
The lib/daos package should be the main repository for
types (e.g. PoolInfo) used throughout the codebase. It
should be possible to import these types without pulling
in extra dependencies (e.g. gRPC, protobufs, etc).

Also reverts an inadvertent change to the system
database's serialization that resulted in 2.4/2.6
incompatibilities.

Required-githooks: true

Change-Id: I2e198a57cc5ae7fe76875c59f2f21eda745ce3e7
Signed-off-by: Michael MacDonald <mjmac@google.com>
As a convenience, provide a "streamlined" version of the pool
query that only performs the minimum amount of work to query
the pool's health. Practically speaking, this means that it
will query for disabled ranks and omit the space query, which
is expensive.

Features: pool
Required-githooks: true
Change-Id: I5abe26c2a9a449a9d7c9c0867ae1fff1de9685d5
Signed-off-by: Michael MacDonald <mjmac@google.com>
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@mjmac mjmac requested a review from jolivier23 May 22, 2024 13:15
@jolivier23 jolivier23 merged commit 7687853 into google/2.4 May 22, 2024
35 checks passed
@jolivier23 jolivier23 deleted the dev/mjmac/DAOS-15794 branch May 22, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants