Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport two CI related patches #14518

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Backport two CI related patches #14518

merged 1 commit into from
Jun 5, 2024

Conversation

jolivier23
Copy link
Contributor

DAOS-15959 cart: Add valgrind suppressions for Go runtime (#14507)

Another Valgrind false positive.

DAOS-623 build: Update packaging to… (#14513)

Pick up a fix from the packaging repo for getting the HPE repository signing key from our Artifactory instead of he HPE servers. This insulates us from management issues with their server such as when they forget to update their certificate.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

DAOS-15959 cart: Add valgrind suppressions for Go runtime (#14507)

Another Valgrind false positive.

Signed-off-by: Kris Jacque <kris.jacque@intel.com>

DAOS-623 build: Update packaging to… (#14513)

Pick up a fix from the packaging repo for getting the HPE repository
signing key from our Artifactory instead of he HPE servers.  This
insulates us from management issues with their server such as when they
forget to update their certificate.

Signed-off-by: Brian J. Murrell <brian.murrell@intel.com>
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

Copy link

github-actions bot commented Jun 5, 2024

Bug-tracker data:
Errors are component not formatted correctly,Ticket number prefix incorrect,PR title is malformatted. See https://daosio.atlassian.net/wiki/spaces/DC/pages/11133911069/Commit+Comments,Unable to load ticket data
https://daosio.atlassian.net/browse/Backport

@jolivier23 jolivier23 merged commit 72f6096 into google/2.4 Jun 5, 2024
32 of 33 checks passed
@jolivier23 jolivier23 deleted the jvolivie/fixes branch June 5, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants