Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16211 vos: Ensure we delete exact entry #14765

Closed
wants to merge 1 commit into from

Conversation

jolivier23
Copy link
Contributor

When the change was made to allow partial overwrite for rebuild, it broke delete such that delete would remove the newest extent rather than the exact one we requested.

Also, don't ignore errors when processing removals

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

When the change was made to allow partial overwrite
for rebuild, it broke delete such that delete would
remove the newest extent rather than the exact one
we requested.

Also, don't ignore errors when processing removals

Required-githooks: true

Signed-off-by: Jeff Olivier <jeffolivier@google.com>
Copy link

Bug-tracker data:
Ticket title is 'Assertion in VOS aggregation (close_merge_window() Assertion '(mw->mw_rmv_cnt == 0)' )'
Status is 'Open'
Labels: 'daos_ecb_issue,daos_ecb_scale,soak,triaged'
https://daosio.atlassian.net/browse/DAOS-16211

@jolivier23 jolivier23 requested a review from mjmac July 12, 2024 22:02
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@jolivier23 jolivier23 removed the request for review from mjmac July 15, 2024 15:26
@jolivier23 jolivier23 closed this Jul 22, 2024
@jolivier23
Copy link
Contributor Author

will reopen when master fix lands.

@jolivier23 jolivier23 deleted the jvolivie/evtree_g2.4 branch July 22, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants