Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16310 test: consolidate il and ioil tags #14881

Merged
merged 3 commits into from
Aug 9, 2024
Merged

DAOS-16310 test: consolidate il and ioil tags #14881

merged 3 commits into from
Aug 9, 2024

Conversation

daltonbohning
Copy link
Contributor

Update il -> ioil for consistency

Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@daltonbohning
DAOS-16310 test: consolidate il and ioil tags
a81b0bc 
Update il -> ioil for consistency

Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
@daltonbohning daltonbohning self-assigned this Aug 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 6, 2024

Ticket title is 'ftest: consolidate il and ioil tags'
Status is 'In Progress'
https://daosio.atlassian.net/browse/DAOS-16310

@daltonbohning daltonbohning marked this pull request as ready for review August 7, 2024 15:13
@daltonbohning daltonbohning requested review from a team as code owners August 7, 2024 15:13
@daltonbohning daltonbohning requested review from wiliamhuang, shimizukko and phender and removed request for a team August 7, 2024 15:13
daltonbohning
daltonbohning commented Aug 7, 2024
View reviewed changes
src/tests/ftest/ior/intercept_messages_pil4dfs.py
@@ -33,7 +33,7 @@ def test_ior_intercept_messages_pil4dfs(self):

:avocado: tags=all,full_regression
:avocado: tags=hw,medium
:avocado: tags=daosio,dfuse,il,ior,ior_intercept,pil4dfs
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wiliamhuang I'm not sure why for some of these that had il and pil4dfs, but do they need ioil? Or JUST pil4dfs?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It needs only "pil4dfs" here.
I probably thought "il" including "ioil" and "pil4dfs" previously.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could make il include both ioil and pil4dfs if that is useful, but it's not 100% the case today

Copy link
Contributor

@wiliamhuang wiliamhuang Aug 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does "dfuse" include both "ioil" and "pil4dfs" already? If yes, then "il" may be not necessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure... Let me check and update if needed. So in total would you be okay with these?

  • dfuse - dfuse-related tests
  • ioil - specifically dfuse + ioil tests
  • pil4dfs - specifically dfuse + pil4dfs tests

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Sounds good to me. Thank you very much!

@daltonbohning daltonbohning marked this pull request as draft August 7, 2024 19:58
@daltonbohning
more updates
438ff3a 
Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14881/2/execution/node/823/log

@daltonbohning
trigger with unstable
c1eec80 
Skip-unit-tests: true
Skip-fault-injection-test: true
Allow-unstable-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14881/3/execution/node/798/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14881/3/execution/node/1105/log

@daltonbohning daltonbohning marked this pull request as ready for review August 9, 2024 13:49
@daltonbohning
Copy link
Contributor Author

Failures in https://build.hpdd.intel.com/blue/organizations/jenkins/daos-stack%2Fdaos/detail/PR-14881/3/tests
mu_perms.py - https://daosio.atlassian.net/browse/DAOS-16301
pil4dfs_fio.py - https://daosio.atlassian.net/browse/DAOS-16315

@daltonbohning daltonbohning requested a review from a team August 9, 2024 13:51
@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Aug 9, 2024
@phender phender merged commit 20625cf into master Aug 9, 2024
45 of 48 checks passed
@phender phender deleted the dbohning/daos-16310 branch August 9, 2024 20:10
daltonbohning added a commit that referenced this pull request Aug 21, 2024
@daltonbohning
DAOS-16310 test: consolidate il and ioil tags (#14881)
7c4b943 
Update il -> ioil for consistency

Skip-unit-tests: true
Skip-fault-injection-test: true
Allow-unstable-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
daltonbohning added a commit that referenced this pull request Aug 22, 2024
@daltonbohning
DAOS-16310 test: consolidate il and ioil tags (#14881) (#14979)
16b5a57 
Update il -> ioil for consistency

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
@juszhan1 juszhan1 mentioned this pull request Aug 26, 2024
Merged
@mjmac mjmac mentioned this pull request Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phender phender phender approved these changes

@wiliamhuang wiliamhuang wiliamhuang approved these changes

@shimizukko shimizukko shimizukko approved these changes

Assignees

@daltonbohning daltonbohning

Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@daltonbohning @daosbuild1 @shimizukko @wiliamhuang @phender