Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16313 build: Add explicit linker flags to lib/daos/api #14889

Merged
merged 1 commit into from
Aug 8, 2024
Merged

DAOS-16313 build: Add explicit linker flags to lib/daos/api #14889

merged 1 commit into from
Aug 8, 2024

Conversation

mjmac
Copy link
Contributor

@mjmac mjmac commented Aug 7, 2024

Apparently these are needed on Ubuntu.

Required-githooks: true

Change-Id: Ieb0446760f0b53e2f09feeae0226ea26dd455d58
Signed-off-by: Michael MacDonald mjmac@google.com

@mjmac mjmac requested review from a team as code owners August 7, 2024 14:58
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024 •
edited
Loading

Ticket title is 'GHA Ubuntu build failing with undefined references'
Status is 'In Review'
https://daosio.atlassian.net/browse/DAOS-16313

tanabarr
tanabarr requested changes Aug 7, 2024
View reviewed changes
.github/workflows/landing-builds.yml Outdated
@@ -1,5 +1,6 @@
name: Landings

# mjmac test (don't land)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this not ready for review yet?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

He modified this file so it would trigger these GHA. They normally only run on landing builds

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, thanks

@mjmac
DAOS-16313 build: Add explicit linker flags to lib/daos/api
9d1503e 
Apparently these are needed on Ubuntu.

Required-githooks: true
Change-Id: Ieb0446760f0b53e2f09feeae0226ea26dd455d58
Signed-off-by: Michael MacDonald <mjmac@google.com>
@mjmac mjmac self-assigned this Aug 7, 2024
@mjmac mjmac added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Aug 7, 2024
@mjmac
Copy link
Contributor Author

mjmac commented Aug 7, 2024

@daltonbohning: Probably makes sense to just force-land this one. I just reverted the workflow change. The previous build successfully passed all of the normal and landings builds.

@daltonbohning
Copy link
Contributor

@daltonbohning: Probably makes sense to just force-land this one. I just reverted the workflow change. The previous build successfully passed all of the normal and landings builds.

Agree

@mjmac
Copy link
Contributor Author

mjmac commented Aug 8, 2024

@tanabarr: Just waiting on you to remove your -1 so this can land, TIA.

@mjmac mjmac merged commit 12b0502 into master Aug 8, 2024
55 checks passed
@mjmac mjmac deleted the mjmac/DAOS-16313 branch August 8, 2024 13:00
@mjmac mjmac mentioned this pull request Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daltonbohning daltonbohning daltonbohning approved these changes

@tanabarr tanabarr tanabarr approved these changes

Assignees

@mjmac mjmac

Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjmac @daltonbohning @tanabarr