Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-14419 control: Display disabled ranks by default #15112

Merged
merged 2 commits into from
Oct 3, 2024
Merged

DAOS-14419 control: Display disabled ranks by default #15112

merged 2 commits into from
Oct 3, 2024

Conversation

knard-intel
Copy link
Contributor

Description

Always display the disabled targets and remove the old associated options.

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@github-actions GitHub Actions
Copy link

Ticket title is 'Display disabled ranks by default'
Status is 'In Progress'
Labels: 'google-cloud-daos,lrz,triaged,usability'
https://daosio.atlassian.net/browse/DAOS-14419

@daosbuild1
Copy link
Collaborator

Test stage Unit Test on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15112/2/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Unit Test on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15112/3/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15112/3/execution/node/1215/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15112/3/execution/node/1524/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15112/3/testReport/

@knard-intel knard-intel self-assigned this Sep 11, 2024
@kanard38 @knard-intel
DAOS-14419 control: Display disabled ranks by default
032b272 
Always display the disabled targets and remove the old associated options.

Features: control
Allow-unstable-test: true
Required-githooks: true
Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@intel.com>
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15112/5/execution/node/1417/log

@knard-intel knard-intel marked this pull request as ready for review September 27, 2024 05:56
@knard-intel knard-intel requested review from a team as code owners September 27, 2024 05:56
mjmac
mjmac approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@mjmac mjmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes LGTM. I wonder if Features: control is enough to validate the test changes, though. @daltonbohning: Do the changed tests get auto-added now?

@knard-intel
Copy link
Contributor Author

knard-intel commented Sep 30, 2024 •
edited
Loading

@daltonbohning , could you tell me if the functional test part is OK for you ?
If not please, could you tell me if there is some other Features tags that I should add.

daltonbohning
daltonbohning reviewed Oct 1, 2024
View reviewed changes
Copy link
Contributor

@daltonbohning daltonbohning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ftest LGTM

@daltonbohning
Copy link
Contributor

The code changes LGTM. I wonder if Features: control is enough to validate the test changes, though. @daltonbohning: Do the changed tests get auto-added now?

Changes to ftest/util map to pr, so don't necessarily cover affected tests. But changes to specific tests do include those specific tests. In this case, I think Features: control is probably sufficient since tests referencing disabled_ranks were updated.

@knard-intel knard-intel requested a review from a team October 1, 2024 20:04
@knard-intel
Copy link
Contributor Author

@daos-stack/daos-gatekeeper please could you land this PR with the following message:

  • Title: DAOS-14419 control: Display disabled ranks by default
  • Body:
    Always display the disabled targets and remove the old associated options.

@mchaarawi mchaarawi merged commit 54c969f into master Oct 3, 2024
55 checks passed
@mchaarawi mchaarawi deleted the ckochhof/fix/master/daos-14419 branch October 3, 2024 13:22
@mjmac mjmac mentioned this pull request Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daltonbohning daltonbohning daltonbohning left review comments

@kjacque kjacque kjacque approved these changes

@tanabarr tanabarr tanabarr approved these changes

@mjmac mjmac mjmac approved these changes

Assignees

@knard-intel knard-intel

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@knard-intel @daosbuild1 @daltonbohning @mjmac @tanabarr @kjacque @mchaarawi @kanard38