Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16577 test: remove hw tag from some manual tests #15138

Merged
merged 1 commit into from
Oct 3, 2024
Merged

DAOS-16577 test: remove hw tag from some manual tests #15138

merged 1 commit into from
Oct 3, 2024

Conversation

daltonbohning
Copy link
Contributor

Remove hw tag from manual tests not expected to work in CI:

  • vmd/fault_reintegration.py
  • vmd/led.py
  • deployment/disk_failure.py

Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@daltonbohning daltonbohning self-assigned this Sep 16, 2024
@github-actions GitHub Actions
Copy link

Ticket title is 'ftest: remove hw tag from manual tests disk_failure.py and fault_reintegration.py'
Status is 'In Progress'
https://daosio.atlassian.net/browse/DAOS-16577

phender
phender previously approved these changes Sep 17, 2024
View reviewed changes
@daltonbohning
Copy link
Contributor Author

To be reconsidered in light of #15166

@daltonbohning
DAOS-16577 test: remove hw tag from some manual tests
aeca0b8 
Remove hw tag from manual tests not expected to work in CI:
- deployment/disk_failure.py

Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
@daltonbohning daltonbohning marked this pull request as ready for review October 1, 2024 16:38
@daltonbohning daltonbohning requested review from a team as code owners October 1, 2024 16:38
@daltonbohning daltonbohning requested a review from a team October 3, 2024 22:22
@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Oct 3, 2024
@daltonbohning
Copy link
Contributor Author

The test did not run, as expected: https://build.hpdd.intel.com/blue/organizations/jenkins/daos-stack%2Fdaos/detail/PR-15138/2/pipeline

@daltonbohning daltonbohning merged commit 7412f3a into master Oct 3, 2024
45 checks passed
@daltonbohning daltonbohning deleted the dbohning/daos-16577 branch October 3, 2024 22:23
daltonbohning added a commit that referenced this pull request Oct 4, 2024
@daltonbohning
DAOS-16577 test: remove hw tag from deployment/disk_failure.py (#15138)
b67bbf6 
Remove hw tag from deployment/disk_failure.py
since it is not expected to work in CI

Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
phender pushed a commit that referenced this pull request Oct 4, 2024
@daltonbohning
DAOS-16577 test: remove hw tag from deployment/disk_failure.py (#15138)…
9c8746e 
… (#15247)

Remove hw tag from deployment/disk_failure.py
since it is not expected to work in CI

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
This was referenced Oct 7, 2024
Closed
Closed
This was referenced Oct 8, 2024
Closed
Merged
@mjmac mjmac mentioned this pull request Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinghwah dinghwah dinghwah approved these changes

@shimizukko shimizukko shimizukko approved these changes

@phender phender Awaiting requested review from phender

@rpadma2 rpadma2 Awaiting requested review from rpadma2

Assignees

@daltonbohning daltonbohning

Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daltonbohning @shimizukko @dinghwah @phender