Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run UT on Leap 15.5 #15148

Draft
wants to merge 13 commits into
base: grom72/ndctl-validation
Choose a base branch
from
Draft

Run UT on Leap 15.5 #15148

wants to merge 13 commits into from
+44 −29

Conversation

brianjmurrell
Copy link
Contributor

Skip-build-el8-rpm: true
Skip-build-el9-rpm: true
Skip-build-leap15-rpm: true
Skip-build-ubuntu20-rpm: true
Skip-test: true
Skip-PR-comments: true
PR-repos: pmdk@PR-38:11

Required-githooks: true

Signed-off-by: Brian J. Murrell brian.murrell@intel.com

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@brianjmurrell
Run UT on Leap 15.5
8bd7dfa 
Skip-build-el8-rpm: true
Skip-build-el9-rpm: true
Skip-build-leap15-rpm: true
Skip-build-ubuntu20-rpm: true
Skip-test: true
Skip-PR-comments: true
PR-repos: pmdk@PR-38:11

Required-githooks: true

Signed-off-by: Brian J. Murrell <brian.murrell@intel.com>
@brianjmurrell brianjmurrell self-assigned this Sep 18, 2024
@brianjmurrell brianjmurrell changed the title Bmurrell/grom72/ndctl-validation/UT-on-Leap15 Run UT on Leap 15.5 Sep 18, 2024
@github-actions GitHub Actions
Copy link

Errors are component not formatted correctly,Ticket number prefix incorrect,PR title is malformatted. See https://daosio.atlassian.net/wiki/spaces/DC/pages/11133911069/Commit+Comments,Unable to load ticket data
https://daosio.atlassian.net/browse/Run

@brianjmurrell
Stash from Leap 15 instead of EL 8
8059774 
Skip-python-bandit: true
Skip-build-el8-rpm: true
Skip-build-el9-rpm: true
Skip-build-leap15-rpm: true
Skip-build-ubuntu20-rpm: true
Skip-test: true
Skip-PR-comments: true
PR-repos: pmdk@PR-38:11

Required-githooks: true

Signed-off-by: Brian J. Murrell <brian.murrell@intel.com>
@brianjmurrell
Updates
6ff8c3b 
Skip-python-bandit: true
Skip-build-el8-rpm: true
Skip-build-el9-rpm: true
Skip-build-leap15-rpm: true
Skip-build-ubuntu20-rpm: true
Skip-test: true
Skip-PR-comments: true
PR-repos: pmdk@PR-38:11

Required-githooks: true

Signed-off-by: Brian J. Murrell <brian.murrell@intel.com>
@brianjmurrell
Use pipeline-lib PR
14be839 
Skip-build: true
Skip-python-bandit: true
Skip-build-el8-rpm: true
Skip-build-el9-rpm: true
Skip-build-leap15-rpm: true
Skip-build-ubuntu20-rpm: true
Skip-test: true
Skip-PR-comments: true
PR-repos: pmdk@PR-38:11

Required-githooks: true

Signed-off-by: Brian J. Murrell <brian.murrell@intel.com>
@brianjmurrell
Update packages needed for UT on Leap 15
6490b63 
Skip-build: false
Skip-python-bandit: true
Skip-build-el8-rpm: true
Skip-build-el9-rpm: true
Skip-build-leap15-rpm: true
Skip-build-ubuntu20-rpm: true
Skip-test: true
Skip-PR-comments: true
PR-repos: pmdk@PR-38:11

Required-githooks: true

Signed-off-by: Brian J. Murrell <brian.murrell@intel.com>
@brianjmurrell
Need a space between names
d9c2ae0 
Skip-build: false
Skip-python-bandit: true
Skip-build-el8-rpm: true
Skip-build-el9-rpm: true
Skip-build-leap15-rpm: true
Skip-build-ubuntu20-rpm: true
Skip-test: true
Skip-PR-comments: true
PR-repos: pmdk@PR-38:11

Required-githooks: true

Signed-off-by: Brian J. Murrell <brian.murrell@intel.com>
@brianjmurrell
libisal-devel for Leap 15
f276791 
Skip-build: false
Skip-python-bandit: true
Skip-build-el8-rpm: true
Skip-build-el9-rpm: true
Skip-build-leap15-rpm: true
Skip-build-ubuntu20-rpm: true
Skip-test: true
Skip-PR-comments: true
PR-repos: pmdk@PR-38:11

Required-githooks: true

Signed-off-by: Brian J. Murrell <brian.murrell@intel.com>
@brianjmurrell
Fix protobuf-c package name
3578bff 
Skip-build: false
Skip-python-bandit: true
Skip-build-el8-rpm: true
Skip-build-el9-rpm: true
Skip-build-leap15-rpm: true
Skip-build-ubuntu20-rpm: true
Skip-test: true
Skip-PR-comments: true
PR-repos: pmdk@PR-38:11

Required-githooks: true

Signed-off-by: Brian J. Murrell <brian.murrell@intel.com>
@brianjmurrell
Don't retry provisioning
20cdef3 
It just doesn't work due to repos being messed up on the subsequent tries.

Skip-build: true
Skip-python-bandit: true
Skip-build-el8-rpm: true
Skip-build-el9-rpm: true
Skip-build-leap15-rpm: true
Skip-build-ubuntu20-rpm: true
Skip-test: true
Skip-PR-comments: true
PR-repos: pmdk@PR-38:11

Required-githooks: true

Signed-off-by: Brian J. Murrell <brian.murrell@intel.com>
@brianjmurrell
Fix protobuf-c package name
1ea1d61 
Skip-build: false
Skip-python-bandit: true
Skip-build-el8-rpm: true
Skip-build-el9-rpm: true
Skip-build-leap15-rpm: true
Skip-build-ubuntu20-rpm: true
Skip-test: true
Skip-PR-comments: true
PR-repos: pmdk@PR-38:11

Required-githooks: true

Signed-off-by: Brian J. Murrell <brian.murrell@intel.com>
@brianjmurrell
Fix stage name to reflect compiler
444e244 
Skip-build: false
Skip-python-bandit: true
Skip-build-el8-rpm: true
Skip-build-el9-rpm: true
Skip-build-leap15-rpm: true
Skip-build-ubuntu20-rpm: true
Skip-test: true
Skip-PR-comments: true
PR-repos: pmdk@PR-38:11

Required-githooks: true

Signed-off-by: Brian J. Murrell <brian.murrell@intel.com>
@brianjmurrell
Add rsync to required packages
6c6d73b 
Skip-build: false
Skip-python-bandit: true
Skip-build-el8-rpm: true
Skip-build-el9-rpm: true
Skip-build-leap15-rpm: true
Skip-build-ubuntu20-rpm: true
Skip-test: true
Skip-PR-comments: true
PR-repos: pmdk@PR-38:11

Required-githooks: true

Signed-off-by: Brian J. Murrell <brian.murrell@intel.com>
@brianjmurrell
Run functional testing with DaosBuild
6006a67 
Skip-build: false
Skip-python-bandit: true
Skip-build-el8-rpm: false
Skip-build-el9-rpm: false
Skip-build-leap15-rpm: false
Skip-build-ubuntu20-rpm: true
Skip-unit-tests: true
Skip-func-test-leap15: false
Skip-func-test-el9: false
Skip-test-leap-15.4-rpms: false
Skip-test-el9-rpms: false
Skip-func-hw-test: true
Test-tag: DaosBuild
PR-repos: pmdk@PR-38:11
Skip-PR-comments: true

Required-githooks: true

Signed-off-by: Brian J. Murrell <brian.murrell@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brianjmurrell brianjmurrell

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@brianjmurrell