Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-13997 control: Allow labels for fault domain levels #15173

Merged
merged 3 commits into from
Sep 27, 2024

Conversation

kjacque
Copy link
Contributor

@kjacque kjacque commented Sep 23, 2024

This patch allows the fault domain levels defined in the server config file to be assigned human-readable labels, for example: /cluster=wolf/rack=123/node=wolf-45

  • Continue allowing fully unlabeled fault paths.
  • Record the domain labels as a management property for the first rank to join. Labels cannot be changed once set.
  • All ranks joining the system must have the same labels.
  • If any domain levels have a label, all of them must. For example, /cluster=wolf/wolf-45 would not be allowed.

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

This patch allows the fault domain levels defined in the server
config file to be assigned human-readable labels, for example:
/cluster=wolf/rack=123/node=wolf-45

- Continue allowing fully unlabeled fault paths.
- Record the domain labels as a management property for the first
  rank to join. Labels cannot be changed once set.
- All ranks joining the system must have the same labels.
- If any domain levels have a label, all of them must. For example,
  /cluster=wolf/wolf-45 would not be allowed.

Required-githooks: true
Signed-off-by: Kris Jacque <kris.jacque@intel.com>
@kjacque kjacque self-assigned this Sep 23, 2024
@kjacque kjacque requested review from a team as code owners September 23, 2024 16:43
Copy link

Ticket title is 'New fault_path format support'
Status is 'In Progress'
https://daosio.atlassian.net/browse/DAOS-13997

@daosbuild1
Copy link
Collaborator

Test stage Unit Test on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15173/2/testReport/

@kjacque kjacque marked this pull request as draft September 23, 2024 22:29
Features: control

Required-githooks: true

Signed-off-by: Kris Jacque <kris.jacque@intel.com>
@kjacque kjacque marked this pull request as ready for review September 24, 2024 15:34
Copy link
Contributor

@mjmac mjmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Are there plans to add ftest coverage for this feature?

@kjacque
Copy link
Contributor Author

kjacque commented Sep 24, 2024

Code LGTM. Are there plans to add ftest coverage for this feature?

We'll definitely need to add ftest coverage, although I think I'll need help from the validation team to test the more complex cases. There's no one on validation assigned to help with this feature yet.

@mjmac mjmac merged commit a1d734a into feature/fault_domain Sep 27, 2024
54 checks passed
@mjmac mjmac deleted the kjacque/fault_domain/fault-path-format branch September 27, 2024 12:34
kjacque added a commit that referenced this pull request Oct 14, 2024
This patch allows the fault domain levels defined in the server
config file to be assigned human-readable labels, for example:
/cluster=wolf/rack=123/node=wolf-45

- Continue allowing fully unlabeled fault paths.
- Record the domain labels as a management property for the first
  rank to join. Labels cannot be changed once set.
- All ranks joining the system must have the same labels.
- If any domain levels have a label, all of them must. For example,
  /cluster=wolf/wolf-45 would not be allowed.

Signed-off-by: Kris Jacque <kris.jacque@intel.com>
daltonbohning pushed a commit that referenced this pull request Oct 23, 2024
…5315)

This patch allows the fault domain levels defined in the server
config file to be assigned human-readable labels, for example:
/cluster=wolf/rack=123/node=wolf-45

- Continue allowing fully unlabeled fault paths.
- Record the domain labels as a management property for the first
  rank to join. Labels cannot be changed once set.
- All ranks joining the system must have the same labels.
- If any domain levels have a label, all of them must. For example,
  /cluster=wolf/wolf-45 would not be allowed.

Signed-off-by: Kris Jacque <kris.jacque@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants