-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAOS-13997 control: Allow labels for fault domain levels #15173
DAOS-13997 control: Allow labels for fault domain levels #15173
Conversation
This patch allows the fault domain levels defined in the server config file to be assigned human-readable labels, for example: /cluster=wolf/rack=123/node=wolf-45 - Continue allowing fully unlabeled fault paths. - Record the domain labels as a management property for the first rank to join. Labels cannot be changed once set. - All ranks joining the system must have the same labels. - If any domain levels have a label, all of them must. For example, /cluster=wolf/wolf-45 would not be allowed. Required-githooks: true Signed-off-by: Kris Jacque <kris.jacque@intel.com>
Ticket title is 'New fault_path format support' |
…ath-format Features: control
Test stage Unit Test on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15173/2/testReport/ |
Features: control Required-githooks: true Signed-off-by: Kris Jacque <kris.jacque@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM. Are there plans to add ftest coverage for this feature?
We'll definitely need to add ftest coverage, although I think I'll need help from the validation team to test the more complex cases. There's no one on validation assigned to help with this feature yet. |
This patch allows the fault domain levels defined in the server config file to be assigned human-readable labels, for example: /cluster=wolf/rack=123/node=wolf-45 - Continue allowing fully unlabeled fault paths. - Record the domain labels as a management property for the first rank to join. Labels cannot be changed once set. - All ranks joining the system must have the same labels. - If any domain levels have a label, all of them must. For example, /cluster=wolf/wolf-45 would not be allowed. Signed-off-by: Kris Jacque <kris.jacque@intel.com>
…5315) This patch allows the fault domain levels defined in the server config file to be assigned human-readable labels, for example: /cluster=wolf/rack=123/node=wolf-45 - Continue allowing fully unlabeled fault paths. - Record the domain labels as a management property for the first rank to join. Labels cannot be changed once set. - All ranks joining the system must have the same labels. - If any domain levels have a label, all of them must. For example, /cluster=wolf/wolf-45 would not be allowed. Signed-off-by: Kris Jacque <kris.jacque@intel.com>
This patch allows the fault domain levels defined in the server config file to be assigned human-readable labels, for example: /cluster=wolf/rack=123/node=wolf-45
Required-githooks: true
Before requesting gatekeeper:
Features:
(orTest-tag*
) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.Gatekeeper: