Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16350 test: decrease pool size for ior_per_rank #15183

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

jamesanunez
Copy link
Collaborator

Test deployment/ior_per_rank fail with 'No space' on some CI clusters. Reduce the requested pool size to accomidate nodes with smaller storage capacity.

Test-tag: test_ior_per_rank
Skip-unit-tests: true
Skip-fault-injection-test: true
Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Copy link

Ticket title is 'deployment/ior_per_rank.py:IorPerRank.test_ior_per_rank - DER_NOSPACE'
Status is 'In Progress'
Labels: 'ci_master_weekly,scrubbed_2.8,weekly_test,testp2'
https://daosio.atlassian.net/browse/DAOS-16350

Test deployment/ior_per_rank fails with 'No space' on some CI
clusters. Reduce the requested pool size to accommodate nodes
with smaller storage capacity.

Skip-func-hw-test-medium-md-on-ssd: false
Skip-unit-tests: true
Skip-fault-injection-test: true
Required-githooks: true

Signed-off-by: James A. Nunez <james.nunez@intel.com>
@jamesanunez
Copy link
Collaborator Author

This PR only changes the size of the per rank pool for the deployment/ior_per_rank test. Results for this PR running Functional Hardware Medium MD on SSD (the test that was failing) are at https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-15183/2/artifact/Functional%20Hardware%20Medium%20MD%20on%20SSD/deployment/ior_per_rank.py/
and the results for Functional Hardware Medium are at https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-15183/2/artifact/Functional%20Hardware%20Medium/deployment/ior_per_rank.py/ .

For this PR to land, do we need to any additional testing or is this testing sufficient to land?
Thanks.

@daltonbohning
Copy link
Contributor

This PR only changes the size of the per rank pool for the deployment/ior_per_rank test. Results for this PR running Functional Hardware Medium MD on SSD (the test that was failing) are at https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-15183/2/artifact/Functional%20Hardware%20Medium%20MD%20on%20SSD/deployment/ior_per_rank.py/ and the results for Functional Hardware Medium are at https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-15183/2/artifact/Functional%20Hardware%20Medium/deployment/ior_per_rank.py/ .

For this PR to land, do we need to any additional testing or is this testing sufficient to land? Thanks.

Since you only modified this one test, it's sufficient to just run this test.

@jamesanunez jamesanunez requested review from mjean308 and a team October 3, 2024 15:23
@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Oct 7, 2024
@daltonbohning daltonbohning merged commit 2738a36 into master Oct 7, 2024
47 checks passed
@daltonbohning daltonbohning deleted the janunez/daos-16350 branch October 7, 2024 18:50
jamesanunez added a commit that referenced this pull request Oct 25, 2024
Test deployment/ior_per_rank fails with 'No space' on some CI
clusters. Reduce the requested pool size to accommodate nodes
with smaller storage capacity.

Signed-off-by: James A. Nunez <james.nunez@intel.com>
jamesanunez added a commit that referenced this pull request Oct 25, 2024
Test deployment/ior_per_rank fails with 'No space' on some CI
clusters. Reduce the requested pool size to accommodate nodes
with smaller storage capacity.

Signed-off-by: James A. Nunez <james.nunez@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Development

Successfully merging this pull request may close these issues.

3 participants