Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16569 test: phase2 VOS unit tests #15195

Merged
merged 2 commits into from
Sep 29, 2024
Merged

DAOS-16569 test: phase2 VOS unit tests #15195

merged 2 commits into from
Sep 29, 2024

Conversation

NiuYawei
Copy link
Contributor

Added VOS unit tests for phase2 pool.

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@NiuYawei
DAOS-16569 test: phase2 VOS unit tests
540621e 
Added VOS unit tests for phase2 pool.

Required-githooks: true

Signed-off-by: Niu Yawei <yawei.niu@intel.com>
@NiuYawei NiuYawei requested review from a team as code owners September 25, 2024 15:01
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 25, 2024 •
edited
Loading

Ticket title is 'VOS unit tests for phase2 mode'
Status is 'In Review'
Labels: 'md_on_ssd2'
https://daosio.atlassian.net/browse/DAOS-16569

jolivier23
jolivier23 reviewed Sep 26, 2024
View reviewed changes
Copy link
Contributor

@jolivier23 jolivier23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should fix the spelling typo

@NiuYawei
DAOS-16569 test: improve unit test
798b66b 
Added punch, aggregation, GC operations.

Required-githooks: true

Signed-off-by: Niu Yawei <yawei.niu@intel.com>
@NiuYawei NiuYawei requested a review from a team as a code owner September 29, 2024 01:39
@NiuYawei NiuYawei merged commit b19a915 into feature/vos_on_blob_p2 Sep 29, 2024
48 of 52 checks passed
@NiuYawei NiuYawei deleted the niu/vos_on_blob_p2/DAOS-16569 branch September 29, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jolivier23 jolivier23 jolivier23 left review comments

@wangshilong wangshilong wangshilong approved these changes

@sherintg sherintg Awaiting requested review from sherintg

@Nasf-Fan Nasf-Fan Awaiting requested review from Nasf-Fan

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NiuYawei @wangshilong @jolivier23