Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16566 test: Update server/multiengine_persocket.py (#15127) #15198

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

phender
Copy link
Contributor

@phender phender commented Sep 25, 2024

Update the server/multiengine_persocket.py test to use test harness methods to ensure compatability with future test harness updates. Also add a test_mode option to allow verification of all but the PMem reconfiguration in CI.

Skip-unit-tests: true
Skip-fault-injection-test: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Update the server/multiengine_persocket.py test to use test harness
methods to ensure compatability with future test harness updates.  Also
add a test_mode option to allow verification of all but the PMem
reconfiguration in CI.

Skip-unit-tests: true
Skip-fault-injection-test: true

Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
@phender phender requested review from a team as code owners September 25, 2024 21:34
Copy link

Ticket title is 'ftest: Update server/multiengine_persocket.py to use test harness methods'
Status is 'Awaiting backport'
Labels: 'manual_test,testp2,request_for_2.6.2'
https://daosio.atlassian.net/browse/DAOS-16566

@phender phender added clean-cherry-pick Cherry-pick from another branch that did not require additional edits forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. labels Sep 26, 2024
@phender phender requested a review from a team October 4, 2024 20:32
@daltonbohning daltonbohning merged commit 18b9138 into release/2.6 Oct 4, 2024
43 checks passed
@daltonbohning daltonbohning deleted the pahender/DAOS-16566 branch October 4, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean-cherry-pick Cherry-pick from another branch that did not require additional edits forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Development

Successfully merging this pull request may close these issues.

2 participants