Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16636 cart: force port range for tcp provider #15209

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

DAOS-16636 cart: force port range for tcp provider #15209

wants to merge 4 commits into from
+50 −7

Conversation

johannlombardi
Copy link
Contributor

Force port range on the client side for the tcp provider and document what ports to open up on firewall.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@johannlombardi
DAOS-16636 cart: force port range for tcp provider
91f8a2f 
Force port range on the client side for the tcp provider and
document what ports to open up on firewall.

Signed-off-by: Johann Lombardi <johann.lombardi@gmail.com>
@github-actions GitHub Actions
Copy link

Ticket title is 'Document firewall rules'
Status is 'Open'
https://daosio.atlassian.net/browse/DAOS-16636

@johannlombardi
Fix nit
206def2 
Signed-off-by: Johann Lombardi <johann.lombardi@gmail.com>
@daosbuild1
Copy link
Collaborator

Test stage Build on Leap 15.5 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15209/2/execution/node/367/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15209/2/execution/node/332/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15209/2/execution/node/373/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.5 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15209/2/execution/node/372/log

@daosbuild1
Copy link
Collaborator

Test stage Build on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15209/2/execution/node/495/log

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15209/2/execution/node/329/log

@johannlombardi
Fix nit
a919e10 
Signed-off-by: Johann Lombardi <johann.lombardi@gmail.com>
@daosbuild1
Copy link
Collaborator

Test stage Build on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15209/3/execution/node/372/log

@daosbuild1
Copy link
Collaborator

Test stage Build on Leap 15.5 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15209/3/execution/node/387/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15209/3/execution/node/347/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15209/3/execution/node/348/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.5 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15209/3/execution/node/342/log

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15209/3/execution/node/339/log

@johannlombardi
Try that
9ce00ca 
Signed-off-by: Johann Lombardi <johann.lombardi@gmail.com>
frostedcmos
frostedcmos reviewed Sep 27, 2024
View reviewed changes
src/cart/crt_init.c
Comment on lines +534 to +539
crt_env_get(FI_TCP_PORT_LOW_RANGE, &port_low_range);
crt_env_get(FI_TCP_PORT_HIGH_RANGE, &port_high_range);

if (port_low_range == UINT32_MAX && port_high_range == UINT32_MAX) {
d_setenv("FI_TCP_PORT_LOW_RANGE", "20100", 0);
d_setenv("FI_TCP_PORT_HIGH_RANGE", "21100", 0);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you need to crt_env_get() high and low beforehand if you are calling d_setenv with overwrite=0 anyway?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

He is only setting them if they aren't set. Note the initial setting to UINT32_MAX on 531/532. This is just setting them to default values.

jolivier23
jolivier23 approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@jolivier23 jolivier23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to figure out what my test case was. I am pretty sure I had issues with doing this. I think it was essentially running multiple clients in a loop. Occasionally, they would fail to get a port. Have you tried opening the first port in the range in another process?

src/cart/crt_internal_types.h
@@ -220,6 +220,8 @@ struct crt_event_cb_priv {
ENV(SWIM_PING_TIMEOUT) \
ENV(SWIM_PROTOCOL_PERIOD_LEN) \
ENV(SWIM_SUSPECT_TIMEOUT) \
ENV(FI_TCP_PORT_LOW_RANGE) \
ENV(FI_TCP_PORT_HIGH_RANGE) \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why putting this in other order would help (saw your last patch).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frostedcmos frostedcmos frostedcmos left review comments

@jolivier23 jolivier23 jolivier23 approved these changes

@mjmac mjmac Awaiting requested review from mjmac

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@johannlombardi @daosbuild1 @jolivier23 @frostedcmos