Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-13938 dfuse: adjust offset in readdir cache entry list #15213

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

jolivier23
Copy link
Contributor

The dfuse readdir caching feature stats entries returned by dfs readdir that might be legimitely deleted by another process or another node. When this happens, the dfuse code decides to skip the deleted entry, but might leave the readdir entry cache in an inconsistent state causing the following assertion failure in dfuse_dre_drop():
drc->drc_next_offset == expected_offset + 1 || drc->drc_next_offset == READDIR_EOD

This patch fixes the offset in the linked list of cached readdir entries to support skipped entries.

Change-Id: Icbd5abb648110559851002301e758128e4ced2c7

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Copy link

Ticket title is 'dFuse process crashes with the following error sporadically on 2.4 branch'
Status is 'Reopened'
Labels: 'GCP,google-cloud-daos'
https://daosio.atlassian.net/browse/DAOS-13938

The dfuse readdir caching feature stats entries returned by
dfs readdir that might be legimitely deleted by another process
or another node. When this happens, the dfuse code decides to
skip the deleted entry, but might leave the readdir entry cache
in an inconsistent state causing the following assertion failure
in dfuse_dre_drop():
drc->drc_next_offset == expected_offset + 1 || drc->drc_next_offset == READDIR_EOD

This patch fixes the offset in the linked list of cached readdir
entries to support skipped entries.

Allow-unstable-test: true

Required-githooks: true

Change-Id: Icbd5abb648110559851002301e758128e4ced2c7
Signed-off-by: Johann Lombardi <johann.lombardi@gmail.com>
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23 jolivier23 force-pushed the jvolivie/backport_jlo_partial_fix branch from 68a3866 to 3f7b438 Compare September 28, 2024 03:11
@wangdi1 wangdi1 self-requested a review October 2, 2024 15:08
@jolivier23 jolivier23 merged commit baad414 into google/2.6 Oct 2, 2024
47 of 49 checks passed
@jolivier23 jolivier23 deleted the jvolivie/backport_jlo_partial_fix branch October 2, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants