Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16714 object: triggering EC degraded fetch before rank eviction. #15342

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wangdi1
Copy link
Contributor

@wangdi1 wangdi1 commented Oct 18, 2024

Triggering EC degraded fetch before rank eviction. So it adds a tried target list for each I/O, if it gets timeout for one target, then the target will be added to the tried list, which will be aovided during the retry. And this list will only be revisited if there are no other alternative choice.

Features: ec rebuild
Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@wangdi1 wangdi1 requested review from a team as code owners October 18, 2024 04:51
@wangdi1 wangdi1 requested review from liuxuezhao and Nasf-Fan and removed request for a team October 18, 2024 04:51
Copy link

github-actions bot commented Oct 18, 2024

Ticket title is 'trigger EC degraded fetch earlier than rank eviction'
Status is 'In Review'
https://daosio.atlassian.net/browse/DAOS-16714

@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15342/1/testReport/

Triggering EC degraded fetch before rank eviction. So it adds a tried
target list for each I/O, if it gets timeout for one target, then the
target will be added to the tried list, which will be aovided during
the retry. And this list will only be revisited if there are no other
alternative choice.

Features: ec rebuild
Required-githooks: true
Signed-off-by: Di Wang <ddiwang@google.com>
@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15342/2/testReport/

@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15342/3/testReport/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants