Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16765 test: pool/verify_space.py - Increase timeout #15453

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

shimizukko
Copy link
Contributor

In the past few passing runs, the test had ~100 sec test time remaining at the end with 600 sec timeout. This means the test usually takes ~500 sec. Set the timeout to
normal test duration * 1.5 = 750 sec

Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test-large-md-on-ssd: false
Test-tag: test_verify_pool_space

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

In the past few passing runs, the test had ~100 sec test time
remaining at the end with 600 sec timeout. This means the
test usually takes ~500 sec. Set the timeout to
normal test duration * 1.5 = 750 sec

Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test-large-md-on-ssd: false
Test-tag: test_verify_pool_space

Signed-off-by: Makito Kano <makito.kano@intel.com>
Copy link

github-actions bot commented Nov 6, 2024

Ticket title is 'pool/verify_space.py:VerifyPoolSpace.test_verify_pool_space - test timeout in tearDown'
Status is 'Open'
Labels: 'weekly_test,md_on_ssd'
https://daosio.atlassian.net/browse/DAOS-16765

Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test-medium-md-on-ssd: false
Test-tag: test_verify_pool_space
Test-repeat: 5
Signed-off-by: Makito Kano <makito.kano@intel.com>
@shimizukko shimizukko marked this pull request as ready for review November 7, 2024 05:30
@shimizukko shimizukko requested review from a team as code owners November 7, 2024 05:30
@shimizukko shimizukko requested a review from a team November 8, 2024 06:21
@phender phender merged commit e3c2a17 into master Nov 8, 2024
46 of 47 checks passed
@phender phender deleted the makito/DAOS-16765 branch November 8, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants