Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16670 test: container/multiple_delete.py - Increase SCM leftover… #15457

Open
wants to merge 1 commit into
base: release/2.6
Choose a base branch
from
Open

DAOS-16670 test: container/multiple_delete.py - Increase SCM leftover… #15457

wants to merge 1 commit into from

Conversation

shimizukko
Copy link
Contributor

…… (#15420)

The object placement algorithm was changed by DAOS-16445. As a result, data are written to targets more uniformly while the amount of leftover data after container destroy/garbage collection in each target remains the same. i.e., Data are written to more targets while the cleanup method in each target hasn't been improved, which results in higher aggregate leftover data.

To handle larger amount of leftover data in SCM, increase the threshold to 1.5MB.

Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test-medium-md-on-ssd: false
Test-tag: test_multiple_container_delete
Test-repeat: 3

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@shimizukko
DAOS-16670 test: container/multiple_delete.py - Increase SCM leftover… (
2241e0b 
#15420)

The object placement algorithm was changed by DAOS-16445. As a result,
data are written to targets more uniformly while the amount of
leftover data after container destroy/garbage collection in each target
remains the same. i.e., Data are written to more targets while the
cleanup method in each target hasn't been improved, which results in
higher aggregate leftover data.

To handle larger amount of leftover data in SCM, increase the threshold
to 1.5MB.

Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-func-hw-test-medium-md-on-ssd: false
Test-tag: test_multiple_container_delete
Test-repeat: 3
Signed-off-by: Makito Kano <makito.kano@intel.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

Ticket title is 'container/multiple_delete.py:MultipleContainerDelete.test_multiple_container_delete - SCM space wasn't recovered!'
Status is 'In Review'
Labels: 'ci_master_weekly,weekly_test,ci_2.6_weekly'
https://daosio.atlassian.net/browse/DAOS-16670

@shimizukko shimizukko added the clean-cherry-pick Cherry-pick from another branch that did not require additional edits label Nov 8, 2024
@shimizukko shimizukko marked this pull request as ready for review November 8, 2024 06:28
@shimizukko shimizukko requested review from a team as code owners November 8, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phender phender phender approved these changes

@daltonbohning daltonbohning daltonbohning approved these changes

Assignees
No one assigned
Labels
clean-cherry-pick Cherry-pick from another branch that did not require additional edits
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shimizukko @daltonbohning @phender