DAOS-16635 control: Pass meta_sz to pool extend+reintegrate API #15459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required-githooks: true Signed-off-by: Tom Nabarro <tom.nabarro@intel.com>
tanabarr
added
control-plane
|
Ticket title is 'Pass meta_sz to pool extend|reintegrate API' |
Features: control Skip-func-hw-test-medium-md-on-ssd: false Skip-func-hw-test-large-md-on-ssd: false Allow-unstable-test: true Required-githooks: true Signed-off-by: Tom Nabarro <tom.nabarro@intel.com>
tanabarr
requested review from
NiuYawei,
mjmac,
kjacque and
knard-intel
and removed request for
a team
|
Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15459/2/execution/node/1186/log |
… ranks ds api Features: control Skip-func-hw-test-medium-md-on-ssd: false Skip-func-hw-test-large-md-on-ssd: false Allow-unstable-test: true Required-githooks: true Signed-off-by: Tom Nabarro <tom.nabarro@intel.com>
Features: control Skip-func-hw-test-medium-md-on-ssd: false Skip-func-hw-test-large-md-on-ssd: false Allow-unstable-test: true Required-githooks: true Signed-off-by: Tom Nabarro <tom.nabarro@intel.com>
tanabarr
force-pushed
the
tanabarr/control-meta_sz-sysdb-mdonssd
branch
from
1f96225
to
acf0e0c
Compare
kjacque
reviewed
Nov 8, 2024
| @@ -34,6 +34,23 @@ import ( | |||
| "github.com/daos-stack/daos/src/control/system/raft" | |||
| ) | |||
|
|
|||
| var ( | |||
| mockTierBytes = []uint64{uint64(1), uint64(2)} | |||
There was a problem hiding this comment.
minor - I don't think these need to be casted within the array
There was a problem hiding this comment.
will fix if I have to repush
tanabarr
changed the title
liw
approved these changes
Nov 13, 2024
kjacque
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable pool extend and reintegrate API to use MD-on-SSD mem-ratio to
calculate differential between VOS-file and META-blob sizes. Add
mem-ratio to RPCs generated by the control-plane and update handlers
to pass different scm_sz and meta_sz values into the API. Update MS-DB
to store pool-specific mem-ratio and inject into relevant requests and
remove unused tgt_dev parameter from engine pool APIs.
Required-githooks: true
Before requesting gatekeeper:
Features:(orTest-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.Gatekeeper: