Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16818 common: Evict NE memory bucket when empty - MD_ON_SSD_p2 #15519

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sherintg
Copy link
Collaborator

Pre-enabler changes to umem_cache_map routine to enable allocator to mark a non-evictable page as evictable and visa-versa. The allocator will make use of the above changes as follows:

  • When all memory blocks in a non-evictable page is marked unused, allocator can mark the entire page as unused and will notify the umem_cache to mark the page as evictable. No further allocations from this memory block will happen from now ownwards.
  • Allocator will request the umem_cache to map the page again as non-evictable when there is a need to extend non-evictable region or as evictable page when a new evictable page has to be reserved.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Pre-enabler changes to umem_cache_map routine to enable allocator to
mark a non-evictable page as evictable and visa-versa. The allocator
will make use of the above changes as follows:
- When all memory blocks in a non-evictable page is marked unused,
  allocator can mark the entire page as unused and will notify the
  umem_cache to mark the page as evictable. No further allocations
  from this memory block will happen from now ownwards.
- Allocator will request the umem_cache to map the page again as
  non-evictable when there is a need to extend non-evictable region
  or as evictable page when a new evictable page has to be reserved.

Signed-off-by: Sherin T George <sherin-t.george@hpe.com>
Copy link

Ticket title is 'Evict NE memory bucket when empty - MD_ON_SSD_p2'
Status is 'Open'
Labels: 'hpe,md_on_ssd2'
https://daosio.atlassian.net/browse/DAOS-16818

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant