DAOS-16814 build: Add tighter checking to patchelf failures. #15522
+26
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check patchelf return codes more strictly, only accept failure for the ond file that fails and only accept one return code. This means that any other failure of patchelf will correctly cause a build failure. Signed-off-by: Ashley Pittman <ashley.m.pittman@intel.com>
|
Ticket title is 'Patchelf errors not failing build.' |
jolivier23
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check patchelf return codes more strictly, only accept
failure for the ond file that fails and only accept one
return code.
This means that any other failure of patchelf will correctly cause
a build failure.
Signed-off-by: Ashley Pittman ashley.m.pittman@intel.com