Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Right pane slightly moves right upon clicking the breadcrumb #2106 #2121

Merged
merged 3 commits into from
Sep 26, 2023
Merged

Right pane slightly moves right upon clicking the breadcrumb #2106 #2121

merged 3 commits into from
Sep 26, 2023

Conversation

andreymikhadyuk
Copy link
Collaborator

@andreymikhadyuk andreymikhadyuk commented Sep 26, 2023 •
edited
Loading

  • PR title equals to the ticket name
  • I added the ticket to the Development section of this PR.

What was changed?

  • fixed the logic of useLockedBody hook
  • added custom body locking to ContextMenu component
  • added new css variable --page-extra-pr to handle scroll lock in fixed elements

@netlify
Copy link

netlify bot commented Sep 26, 2023 •
edited
Loading

✅ Deploy Preview for preview-common ready!

Name Link
🔨 Latest commit 89bc0d5
🔍 Latest deploy log https://app.netlify.com/sites/preview-common/deploys/6512e0fec7f0d90008cb1ecb
😎 Deploy Preview https://deploy-preview-2121--preview-common.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andreymikhadyuk andreymikhadyuk linked an issue Sep 26, 2023 that may be closed by this pull request
Right pane slightly moves right upon clicking the breadcrumb #2106
Closed
@andreymikhadyuk andreymikhadyuk merged commit 0baefe6 into dev Sep 26, 2023
5 checks passed
@andreymikhadyuk andreymikhadyuk deleted the bugfix/CW-2106-body-scroll-width branch September 26, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@budnik9 budnik9 budnik9 approved these changes

@roienatan roienatan Awaiting requested review from roienatan

@MeyerPV MeyerPV Awaiting requested review from MeyerPV

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Right pane slightly moves right upon clicking the breadcrumb
2 participants
@andreymikhadyuk @budnik9