-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mobile - navigate to the last space upon clicking My spaces #2099 #2144
Conversation
✅ Deploy Preview for preview-common ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@andreymikhadyuk |
@elatif2020 Delay is based on #2116. I can remove it for mobile. |
@elatif2020 Is such loading view ok? |
@andreymikhadyuk |
I will do it only for the new version, ok? |
Did it for new layout. |
@elatif2020 The thing with small jump was on my side and I fixed it. Please double-check in the preview. |
@andreymikhadyuk |
Where do you test it? For me works fine. |
Firefox, both in the computer responsive mode and in my phone |
Could you please do a screen sharing? For me on Phone's Safari and Chrome, in responsive Chrome and Firefox it works fine. |
see the second time here |
Development
section of this PR.What was changed?
lastCommonIdFromFeed
field which is used to open correct common/space on clickingFeed
tab. If there was no last common/space, then sidenav still will be open