Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile - navigate to the last space upon clicking My spaces #2099 #2144

Merged
merged 10 commits into from
Oct 5, 2023

Conversation

andreymikhadyuk
Copy link
Collaborator

@andreymikhadyuk andreymikhadyuk commented Oct 4, 2023

  • PR title equals to the ticket name
  • I added the ticket to the Development section of this PR.

What was changed?

  • added lastCommonIdFromFeed field which is used to open correct common/space on clicking Feed tab. If there was no last common/space, then sidenav still will be open

@netlify
Copy link

netlify bot commented Oct 4, 2023

Deploy Preview for preview-common ready!

Name Link
🔨 Latest commit 6c75baf
🔍 Latest deploy log https://app.netlify.com/sites/preview-common/deploys/651ea62e6842a5000869ffbe
😎 Deploy Preview https://deploy-preview-2144--preview-common.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@elatif2020
Copy link
Collaborator

@andreymikhadyuk
When I click feed on mobile there is a white screen for a second. Can we avoid this (and keep the tabs menu and maybe header visible)?

@andreymikhadyuk
Copy link
Collaborator Author

@andreymikhadyuk When I click feed on mobile there is a white screen for a second. Can we avoid this (and keep the tabs menu and maybe header visible)?

@elatif2020 Delay is based on #2116. I can remove it for mobile.

@andreymikhadyuk
Copy link
Collaborator Author

@elatif2020 Is such loading view ok?
image

@elatif2020
Copy link
Collaborator

@elatif2020 Is such loading view ok? image

@andreymikhadyuk
Better if we can keep in memory the header info of the current common and load it instantly

@andreymikhadyuk
Copy link
Collaborator Author

@elatif2020 Is such loading view ok? image

@andreymikhadyuk Better if we can keep in memory the header info of the current common and load it instantly

I will do it only for the new version, ok?

@andreymikhadyuk
Copy link
Collaborator Author

@elatif2020 Is such loading view ok? image

@andreymikhadyuk Better if we can keep in memory the header info of the current common and load it instantly

Did it for new layout.

@andreymikhadyuk
Copy link
Collaborator Author

@elatif2020 The thing with small jump was on my side and I fixed it. Please double-check in the preview.

@elatif2020
Copy link
Collaborator

@elatif2020 The thing with small jump was on my side and I fixed it. Please double-check in the preview.

@andreymikhadyuk
I still see this blink for a second

@andreymikhadyuk andreymikhadyuk merged commit fd14d20 into dev Oct 5, 2023
5 checks passed
@andreymikhadyuk andreymikhadyuk deleted the feature/CW-2099-last-space-navigation branch October 5, 2023 13:47
@andreymikhadyuk
Copy link
Collaborator Author

@elatif2020 The thing with small jump was on my side and I fixed it. Please double-check in the preview.

@andreymikhadyuk I still see this blink for a second

Where do you test it? For me works fine.

@elatif2020
Copy link
Collaborator

@elatif2020 The thing with small jump was on my side and I fixed it. Please double-check in the preview.

@andreymikhadyuk I still see this blink for a second

Where do you test it? For me works fine.

Firefox, both in the computer responsive mode and in my phone

@andreymikhadyuk
Copy link
Collaborator Author

@elatif2020 The thing with small jump was on my side and I fixed it. Please double-check in the preview.

@andreymikhadyuk I still see this blink for a second

Where do you test it? For me works fine.

Firefox, both in the computer responsive mode and in my phone

Could you please do a screen sharing? For me on Phone's Safari and Chrome, in responsive Chrome and Firefox it works fine.

@elatif2020
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile - navigate to the last space upon clicking My spaces
3 participants