Instant opening of a stream #2729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added OptimisticDiscussion type. Added optimistic store values. Added support for optimistic messages for Discussions
✅ Deploy Preview for preview-common ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…ommon-web into CW-Optimistic-streams
Full support of proposal optimistic streams Clean up code
Remove unnecessary code
|
@MeyerPV somehow we still have 2+ sec loader appearing after clicking Publish. Can we shorten this? Actually I think the new stream appears already before, but the discussion creation form hangs longer |
Added instant close on creation modal
|
@MeyerPV see the recording here
|
Improvements
Improvements to optimistic: 1. Fixed glitched in card while transitioning from Optimistic to Real 2. Added focuses for ChatComponent and DiscussionCreation 3. Remove unnecessary proposalCreation modal
elatif2020
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://daostack.notion.site/Instant-opening-of-a-stream-d588a3bf0ed84cee8d2fa50ff8b58b01?pvs=74
What was changed?