Update NBA contracts & txs to Cadence 1.0 #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Followed up on a few of my comments that were never addressed and left a few more. The changes will require the contracts to be re-staged on testnet after you address them. Let me know before you want to re-stage so I can verify that everything has been addressed
contracts/FastBreakV1.cdc
Outdated
Comment on lines
30
to
32
| access(all) event Withdraw(id: UInt64, from: Address?) | ||
|
|
||
| pub event Deposit(id: UInt64, to: Address?) | ||
| access(all) event Deposit(id: UInt64, to: Address?) |
There was a problem hiding this comment.
I'd recommend removing these because the default NonFungibleToken events are much better
contracts/TopShot.cdc
Outdated
| @@ -1191,7 +1224,7 @@ pub contract TopShot: NonFungibleToken { | |||
|
|
|||
| // lock takes a token id and a duration in seconds and locks | |||
| // the moment for that duration | |||
| pub fun lock(id: UInt64, duration: UFix64) { | |||
| access(NonFungibleToken.Update | NonFungibleToken.Owner) fun lock(id: UInt64, duration: UFix64) { | |||
There was a problem hiding this comment.
Can you include this event emission here?
* cadence 1 upgrade * fix tests * token updated
Updated FastbreakV1 for Staging
* Bump golang.org/x/net from 0.19.0 to 0.23.0 in /lib/go/test Bumps [golang.org/x/net](https://github.com/golang/net) from 0.19.0 to 0.23.0. - [Commits](golang/net@v0.19.0...v0.23.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * generated --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Taylor Petrychyn <taylor.petrychyn@dapperlabs.com>
Upgrade flow go sdk
* Fix tests * ci * Update go version
…nftUpdated event call, as it was already being called
Added events validation
NBA-2865: Fixed event unit tests
Fixed issues on events decoding
Add new destroy event name
…n-script Fixed check collection script
Fixed MarketPlace Contracts
* save cap on storage * fix var / entitlements * add comments and V1 Sale handling to create and start sale collection (#266) --------- Co-authored-by: Joshua Hannan <hannanjoshua19@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.