Add assert approx and assert false #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🥇 |
PaulRBerg
reviewed
Jul 8, 2022
Comment on lines
+72
to
+77
| function assertFalse(bool condition) internal { | ||
| if (condition) { | ||
| emit log("Error: Assertion Failed"); | ||
| fail(); | ||
| } | ||
| } |
There was a problem hiding this comment.
Couldn't this simply call assertTrue like this?
function assertFalse(bool condition) internal {
assertTrue(!condition);
}
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has been opened to add 2 functionalities:
assertApproxEq: allows to do testing with an approximation given as input (to avoid small rounding errors).assertFalse: The opposite ofassertFalsefor convenience.It seems there is a duplicate PR for
assertFalsehere so we can just merge it and only add the commit for theassertApproxEqfrom this PR or simply just merge this PR 🙂Thanks for you feedbacks!