Drop beacon_chain pubkey to index map cache #17
Conversation
| /// Rebase state pubkey_cache on some existing state to prevent re-populating the cache on the | ||
| /// first process_deposit call. | ||
| fn rebase_caches(&self, state: &mut BeaconState<E>) { | ||
| if let Ok((_, first_state)) = self.state_cache.lock().iter().exactly_one() { | ||
| state.rebase_caches_on(first_state); | ||
| } | ||
| } |
There was a problem hiding this comment.
@michaelsproul is it possible to access the head state here?
(2) Those the state_cache always include the head state?
(3) Is the state_cache guaranteed to never be empty?
There was a problem hiding this comment.
Oh, on unstable that state_cache is just for historic states. It would be better named historic_state_cache.
The state_cache on tree-states can guarantee that the finalized state is always present. See:
(the Option is just for first-time initialization)
In summary:
- No, but you could get the
finalizedstate ontree-states. I think that would work? - Definitely not on unstable (head is not historic), and probably yes (but not guaranteed) on
tree-states. - On unstable, no; on tree-states, yes.
There was a problem hiding this comment.
Might be best to postpone this PR for post tree-states then
dapplion
force-pushed
the
shared-pubkey-cache
branch
from
695b3e4
to
aac5f19
Compare
dapplion
force-pushed
the
shared-pubkey-cache
branch
from
aac5f19
to
bd682be
Compare
| @@ -1529,7 +1529,8 @@ mod release_tests { | |||
| let (harness, _) = sync_contribution_test_state::<MainnetEthSpec>(1).await; | |||
|
|
|||
| let op_pool = OperationPool::<MainnetEthSpec>::new(); | |||
| let state = harness.get_current_state(); | |||
| let mut state = harness.get_current_state(); | |||
| state.update_pubkey_cache().unwrap(); | |||
There was a problem hiding this comment.
@michaelsproul could not figure out where the caches are lost. The genesis state in the harness builds the caches but they are lost along the way. Maybe while advancing the blocks?
There was a problem hiding this comment.
Not sure, can dig into this if it's still a problem later
Issue Addressed
With current spec, the pubkey to index map could be a global cache. Right now this cache is duplicated in:
This PR drops the copy in the BeaconChain struct, making its consumers use some state instead.