Add blob sidecar inclusion test #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapplion
merged commit 8c26db7
into
dapplion:blob-inclusion-fallible
21 of 24 checks passed
dapplion
added a commit
that referenced
this pull request
Jun 19, 2024
* Verify inclusion proof should not be fallible * Add blob sidecar inclusion test (#33) * Add blob sidecar inclusion test. * Fix lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Wrote some test to verify inclusion proof.
I wasn't sure if we have any tests for this, and it doesn't seem to fit nicely with the spec tests as the verify function is on
BlobSidecar, so I copied some logic fromExecutionBlockGeneratorand simplified it - I think this would be useful in thetypescrate without theexecution_layerand other dependencies.